From: Jakub Kicinski <kuba@kernel•org>
To: Marcin Szycik <marcin.szycik@linux•intel.com>
Cc: netdev@vger•kernel.org, anthony.l.nguyen@intel•com,
davem@davemloft•net, xiyou.wangcong@gmail•com,
jesse.brandeburg@intel•com, gustavoars@kernel•org,
baowen.zheng@corigine•com, boris.sukholitko@broadcom•com,
edumazet@google•com, jhs@mojatatu•com, jiri@resnulli•us,
kurt@linutronix•de, pablo@netfilter•org, pabeni@redhat•com,
paulb@nvidia•com, simon.horman@corigine•com,
komachi.yoshiki@gmail•com, zhangkaiheb@126•com,
intel-wired-lan@lists•osuosl.org,
michal.swiatkowski@linux•intel.com, wojciech.drewek@intel•com,
alexandr.lobakin@intel•com
Subject: Re: [RFC PATCH net-next v2 1/4] flow_dissector: Add PPPoE dissectors
Date: Tue, 28 Jun 2022 21:40:20 -0700 [thread overview]
Message-ID: <20220628214020.0f83fc21@kernel.org> (raw)
In-Reply-To: <20220628112918.11296-2-marcin.szycik@linux.intel.com>
On Tue, 28 Jun 2022 13:29:15 +0200 Marcin Szycik wrote:
> +static bool is_ppp_proto_supported(__be16 proto)
What does supported mean in this context?
> +{
> + switch (ntohs(proto)) {
> + case PPP_AT:
Byte swap on the constant.
> + case PPP_IPX:
> + case PPP_VJC_COMP:
> + case PPP_VJC_UNCOMP:
> + case PPP_MP:
> + case PPP_COMPFRAG:
> + case PPP_COMP:
> + case PPP_MPLS_UC:
> + case PPP_MPLS_MC:
> + case PPP_IPCP:
> + case PPP_ATCP:
> + case PPP_IPXCP:
> + case PPP_IPV6CP:
> + case PPP_CCPFRAG:
> + case PPP_MPLSCP:
> + case PPP_LCP:
> + case PPP_PAP:
> + case PPP_LQR:
> + case PPP_CHAP:
> + case PPP_CBCP:
> + return true;
> + default:
> + return false;
> + }
> +}
next prev parent reply other threads:[~2022-06-29 4:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 11:29 [RFC PATCH net-next v2 0/4] ice: PPPoE offload support Marcin Szycik
2022-06-28 11:29 ` [RFC PATCH net-next v2 1/4] flow_dissector: Add PPPoE dissectors Marcin Szycik
2022-06-29 4:40 ` Jakub Kicinski [this message]
2022-06-29 7:44 ` Drewek, Wojciech
2022-06-29 15:19 ` Jakub Kicinski
2022-07-01 10:58 ` Drewek, Wojciech
2022-06-28 11:29 ` [RFC PATCH net-next v2 2/4] net/sched: flower: Add PPPoE filter Marcin Szycik
2022-06-28 11:29 ` [RFC PATCH net-next v2 3/4] flow_offload: Introduce flow_match_pppoe Marcin Szycik
2022-06-28 11:29 ` [RFC PATCH net-next v2 4/4] ice: Add support for PPPoE hardware offload Marcin Szycik
2022-06-29 4:39 ` [RFC PATCH net-next v2 0/4] ice: PPPoE offload support Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628214020.0f83fc21@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=alexandr.lobakin@intel$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=baowen.zheng@corigine$(echo .)com \
--cc=boris.sukholitko@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gustavoars@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=komachi.yoshiki@gmail$(echo .)com \
--cc=kurt@linutronix$(echo .)de \
--cc=marcin.szycik@linux$(echo .)intel.com \
--cc=michal.swiatkowski@linux$(echo .)intel.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
--cc=paulb@nvidia$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=wojciech.drewek@intel$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
--cc=zhangkaiheb@126$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox