From: Jakub Kicinski <kuba@kernel•org>
To: "Drewek, Wojciech" <wojciech.drewek@intel•com>
Cc: Marcin Szycik <marcin.szycik@linux•intel.com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"xiyou.wangcong@gmail•com" <xiyou.wangcong@gmail•com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel•com>,
"gustavoars@kernel•org" <gustavoars@kernel•org>,
"baowen.zheng@corigine•com" <baowen.zheng@corigine•com>,
"boris.sukholitko@broadcom•com" <boris.sukholitko@broadcom•com>,
"edumazet@google•com" <edumazet@google•com>,
"jhs@mojatatu•com" <jhs@mojatatu•com>,
"jiri@resnulli•us" <jiri@resnulli•us>,
"kurt@linutronix•de" <kurt@linutronix•de>,
"pablo@netfilter•org" <pablo@netfilter•org>,
"pabeni@redhat•com" <pabeni@redhat•com>,
"paulb@nvidia•com" <paulb@nvidia•com>,
"simon.horman@corigine•com" <simon.horman@corigine•com>,
"komachi.yoshiki@gmail•com" <komachi.yoshiki@gmail•com>,
"zhangkaiheb@126•com" <zhangkaiheb@126•com>,
"intel-wired-lan@lists•osuosl.org"
<intel-wired-lan@lists•osuosl.org>,
"michal.swiatkowski@linux•intel.com"
<michal.swiatkowski@linux•intel.com>,
"Lobakin, Alexandr" <alexandr.lobakin@intel•com>
Subject: Re: [RFC PATCH net-next v2 1/4] flow_dissector: Add PPPoE dissectors
Date: Wed, 29 Jun 2022 08:19:37 -0700 [thread overview]
Message-ID: <20220629081937.7270e7d7@kernel.org> (raw)
In-Reply-To: <MW4PR11MB57761A084A3A556F4070F8CDFDBB9@MW4PR11MB5776.namprd11.prod.outlook.com>
On Wed, 29 Jun 2022 07:44:50 +0000 Drewek, Wojciech wrote:
> > > +static bool is_ppp_proto_supported(__be16 proto)
> >
> > What does supported mean in this context?
>
> It means that only those protocols are going to be dissected.
We only dissect PPP_IP and PPP_IPV6. This looks more like a list of all
known protocols.
next prev parent reply other threads:[~2022-06-29 15:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 11:29 [RFC PATCH net-next v2 0/4] ice: PPPoE offload support Marcin Szycik
2022-06-28 11:29 ` [RFC PATCH net-next v2 1/4] flow_dissector: Add PPPoE dissectors Marcin Szycik
2022-06-29 4:40 ` Jakub Kicinski
2022-06-29 7:44 ` Drewek, Wojciech
2022-06-29 15:19 ` Jakub Kicinski [this message]
2022-07-01 10:58 ` Drewek, Wojciech
2022-06-28 11:29 ` [RFC PATCH net-next v2 2/4] net/sched: flower: Add PPPoE filter Marcin Szycik
2022-06-28 11:29 ` [RFC PATCH net-next v2 3/4] flow_offload: Introduce flow_match_pppoe Marcin Szycik
2022-06-28 11:29 ` [RFC PATCH net-next v2 4/4] ice: Add support for PPPoE hardware offload Marcin Szycik
2022-06-29 4:39 ` [RFC PATCH net-next v2 0/4] ice: PPPoE offload support Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629081937.7270e7d7@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=alexandr.lobakin@intel$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=baowen.zheng@corigine$(echo .)com \
--cc=boris.sukholitko@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gustavoars@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=komachi.yoshiki@gmail$(echo .)com \
--cc=kurt@linutronix$(echo .)de \
--cc=marcin.szycik@linux$(echo .)intel.com \
--cc=michal.swiatkowski@linux$(echo .)intel.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
--cc=paulb@nvidia$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=wojciech.drewek@intel$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
--cc=zhangkaiheb@126$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox