From: Kuniyuki Iwashima <kuniyu@amazon•com>
To: <kuba@kernel•org>
Cc: <davem@davemloft•net>, <ebiederm@xmission•com>,
<edumazet@google•com>, <herbert@gondor•apana.org.au>,
<kuni1840@gmail•com>, <kuniyu@amazon•com>,
<netdev@vger•kernel.org>, <pabeni@redhat•com>, <xemul@openvz•org>
Subject: Re: [PATCH v3 net] af_unix: Do not call kmemdup() for init_net's sysctl table.
Date: Tue, 28 Jun 2022 20:55:46 -0700 [thread overview]
Message-ID: <20220629035546.58196-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20220628205125.2b443819@kernel.org>
From: Jakub Kicinski <kuba@kernel•org>
Date: Tue, 28 Jun 2022 20:51:25 -0700
> On Mon, 27 Jun 2022 16:36:27 -0700 Kuniyuki Iwashima wrote:
> > While setting up init_net's sysctl table, we need not duplicate the
> > global table and can use it directly as ipv4_sysctl_init_net() does.
> >
> > Unlike IPv4, AF_UNIX does not have a huge sysctl table for now, so it
> > cannot be a problem, but this patch makes code consistent.
>
> Thanks for the extra info. It sounds like an optimization, tho.
> We save one table's worth of memory. Any objections to applying
> this to net-next?
I'm fine with net-next.
Thank you,
Kuniyuki
> > Fixes: 1597fbc0faf8 ("[UNIX]: Make the unix sysctl tables per-namespace")
> > Acked-by: Eric W. Biederman <ebiederm@xmission•com>
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon•com>
next prev parent reply other threads:[~2022-06-29 3:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 23:36 [PATCH v3 net] af_unix: Do not call kmemdup() for init_net's sysctl table Kuniyuki Iwashima
2022-06-29 3:51 ` Jakub Kicinski
2022-06-29 3:55 ` Kuniyuki Iwashima [this message]
2022-06-29 4:10 ` patchwork-bot+netdevbpf
2022-07-08 16:10 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629035546.58196-1-kuniyu@amazon.com \
--to=kuniyu@amazon$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=kuba@kernel$(echo .)org \
--cc=kuni1840@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=xemul@openvz$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox