From: Jakub Kicinski <kuba@kernel•org>
To: Vladimir Oltean <vladimir.oltean@nxp•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Vivien Didelot" <vivien.didelot@gmail•com>,
"Andrew Lunn" <andrew@lunn•ch>,
"Vladimir Oltean" <olteanv@gmail•com>,
"Claudiu Manoil" <claudiu.manoil@nxp•com>,
"Alexandre Belloni" <alexandre.belloni@bootlin•com>,
UNGLinuxDriver@microchip•com,
"Colin Foster" <colin.foster@in-advantage•com>,
"Roopa Prabhu" <roopa@nvidia•com>,
"Nikolay Aleksandrov" <razor@blackwall•org>,
"Tobias Waldekranz" <tobias@waldekranz•com>,
"Marek Behún" <kabel@kernel•org>,
"Ansuel Smith" <ansuelsmth@gmail•com>,
"DENG Qingfang" <dqfext@gmail•com>,
"Alvin Šipraga" <alsi@bang-olufsen•dk>,
"Linus Walleij" <linus.walleij@linaro•org>,
"Luiz Angelo Daros de Luca" <luizluca@gmail•com>,
"Felix Fietkau" <nbd@nbd•name>, "John Crispin" <john@phrozen•org>,
"Sean Wang" <sean.wang@mediatek•com>
Subject: Re: [PATCH net-next 3/9] net: dsa: allow the DSA master to be seen and changed through rtnetlink
Date: Wed, 31 Aug 2022 20:50:20 -0700 [thread overview]
Message-ID: <20220831205020.28fbfcc5@kernel.org> (raw)
In-Reply-To: <20220830195932.683432-4-vladimir.oltean@nxp.com>
On Tue, 30 Aug 2022 22:59:26 +0300 Vladimir Oltean wrote:
> Some DSA switches have multiple CPU ports, which can be used to improve
> CPU termination throughput, but DSA, through dsa_tree_setup_cpu_ports(),
> sets up only the first one, leading to suboptimal use of hardware.
>
> The desire is to not change the default configuration but to permit the
> user to create a dynamic mapping between individual user ports and the
> CPU port that they are served by, configurable through rtnetlink. It is
> also intended to permit load balancing between CPU ports, and in that
> case, the foreseen model is for the DSA master to be a bonding interface
> whose lowers are the physical DSA masters.
>
> To that end, we create a struct rtnl_link_ops for DSA user ports with
> the "dsa" kind. We expose the IFLA_DSA_MASTER link attribute that
> contains the ifindex of the newly desired DSA master.
net/dsa/port.c: In function ‘dsa_port_change_master’:
net/dsa/port.c:1414:13: warning: unused variable ‘port’ [-Wunused-variable]
1414 | int port = dp->index;
| ^~~~
I presume you had a look around what side effects setting rtnl_link_ops
will have? Should .netns_refund be true?
next prev parent reply other threads:[~2022-09-01 3:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 19:59 [PATCH net-next 0/9] DSA changes for multiple CPU ports (part 4) Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 1/9] net: introduce iterators over synced hw addresses Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 2/9] net: dsa: introduce dsa_port_get_master() Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 3/9] net: dsa: allow the DSA master to be seen and changed through rtnetlink Vladimir Oltean
2022-09-01 3:50 ` Jakub Kicinski [this message]
2022-09-01 13:29 ` Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 4/9] net: dsa: don't keep track of admin/oper state on LAG DSA masters Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 5/9] net: dsa: suppress appending ethtool stats to " Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 6/9] net: dsa: suppress device links " Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 7/9] net: dsa: allow masters to join a LAG Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 8/9] docs: net: dsa: update information about multiple CPU ports Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 9/9] net: dsa: felix: add support for changing DSA master Vladimir Oltean
2022-09-02 10:31 ` [PATCH net-next 0/9] DSA changes for multiple CPU ports (part 4) Vladimir Oltean
2022-09-02 18:33 ` Florian Fainelli
2022-09-02 18:40 ` Vladimir Oltean
2022-09-03 2:48 ` Marek Behún
2022-09-04 15:41 ` Vladimir Oltean
2022-09-02 18:44 ` Christian Marangi
2022-09-03 2:50 ` Marek Behún
2022-09-04 19:34 ` Vladimir Oltean
2022-09-06 16:10 ` Colin Foster
2022-09-06 16:18 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220831205020.28fbfcc5@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=alsi@bang-olufsen$(echo .)dk \
--cc=andrew@lunn$(echo .)ch \
--cc=ansuelsmth@gmail$(echo .)com \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=colin.foster@in-advantage$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dqfext@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=john@phrozen$(echo .)org \
--cc=kabel@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=luizluca@gmail$(echo .)com \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=roopa@nvidia$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
--cc=tobias@waldekranz$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox