From: Florian Fainelli <f.fainelli@gmail•com>
To: Vladimir Oltean <vladimir.oltean@nxp•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Cc: "linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Vivien Didelot" <vivien.didelot@gmail•com>,
"Andrew Lunn" <andrew@lunn•ch>,
"Vladimir Oltean" <olteanv@gmail•com>,
"Claudiu Manoil" <claudiu.manoil@nxp•com>,
"Alexandre Belloni" <alexandre.belloni@bootlin•com>,
"UNGLinuxDriver@microchip•com" <UNGLinuxDriver@microchip•com>,
"Colin Foster" <colin.foster@in-advantage•com>,
"Roopa Prabhu" <roopa@nvidia•com>,
"Nikolay Aleksandrov" <razor@blackwall•org>,
"Tobias Waldekranz" <tobias@waldekranz•com>,
"Marek Behún" <kabel@kernel•org>,
"Ansuel Smith" <ansuelsmth@gmail•com>,
"DENG Qingfang" <dqfext@gmail•com>,
"Alvin Šipraga" <alsi@bang-olufsen•dk>,
"Linus Walleij" <linus.walleij@linaro•org>,
"Luiz Angelo Daros de Luca" <luizluca@gmail•com>,
"Felix Fietkau" <nbd@nbd•name>, "John Crispin" <john@phrozen•org>,
"Sean Wang" <sean.wang@mediatek•com>
Subject: Re: [PATCH net-next 0/9] DSA changes for multiple CPU ports (part 4)
Date: Fri, 2 Sep 2022 11:33:31 -0700 [thread overview]
Message-ID: <3da14763-b495-77eb-e059-b62e496ba7e7@gmail.com> (raw)
In-Reply-To: <20220902103145.faccoawnaqh6cn3r@skbuf>
On 9/2/2022 3:31 AM, Vladimir Oltean wrote:
> On Tue, Aug 30, 2022 at 10:59:23PM +0300, Vladimir Oltean wrote:
>> This series represents the final part of that effort. We have:
>>
>> - the introduction of new UAPI in the form of IFLA_DSA_MASTER
>
> Call for opinions: when I resend this, should I keep rtnl_link_ops,
> or should I do what Marek attempted to do, and make the existing iflink
> between a user port and its master writable from user space?
> https://lore.kernel.org/netdev/20190824024251.4542-4-marek.behun@nic.cz/
>
> I'm not sure if we have that many more use cases for rtnl_link_ops..
It's a bit hard to see one right now, I agree.
> at some point I was thinking we could change the way in which dsa_loop
> probes, and allow dynamic creation of such interfaces using RTM_NEWLINK;
> but looking closer at that, it's a bit more complicated, since we'd need
> to attach dsa_loop user ports to a virtual switch, and probe all ports
> at the same time rather than one by one.
Yes, not sure the custom netlink operations would be the preferred way
of doing that configuration, maybe module parameters and/or debugfs
might just do?
--
Florian
next prev parent reply other threads:[~2022-09-02 18:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 19:59 [PATCH net-next 0/9] DSA changes for multiple CPU ports (part 4) Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 1/9] net: introduce iterators over synced hw addresses Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 2/9] net: dsa: introduce dsa_port_get_master() Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 3/9] net: dsa: allow the DSA master to be seen and changed through rtnetlink Vladimir Oltean
2022-09-01 3:50 ` Jakub Kicinski
2022-09-01 13:29 ` Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 4/9] net: dsa: don't keep track of admin/oper state on LAG DSA masters Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 5/9] net: dsa: suppress appending ethtool stats to " Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 6/9] net: dsa: suppress device links " Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 7/9] net: dsa: allow masters to join a LAG Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 8/9] docs: net: dsa: update information about multiple CPU ports Vladimir Oltean
2022-08-30 19:59 ` [PATCH net-next 9/9] net: dsa: felix: add support for changing DSA master Vladimir Oltean
2022-09-02 10:31 ` [PATCH net-next 0/9] DSA changes for multiple CPU ports (part 4) Vladimir Oltean
2022-09-02 18:33 ` Florian Fainelli [this message]
2022-09-02 18:40 ` Vladimir Oltean
2022-09-03 2:48 ` Marek Behún
2022-09-04 15:41 ` Vladimir Oltean
2022-09-02 18:44 ` Christian Marangi
2022-09-03 2:50 ` Marek Behún
2022-09-04 19:34 ` Vladimir Oltean
2022-09-06 16:10 ` Colin Foster
2022-09-06 16:18 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3da14763-b495-77eb-e059-b62e496ba7e7@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=alsi@bang-olufsen$(echo .)dk \
--cc=andrew@lunn$(echo .)ch \
--cc=ansuelsmth@gmail$(echo .)com \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=colin.foster@in-advantage$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dqfext@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=john@phrozen$(echo .)org \
--cc=kabel@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=luizluca@gmail$(echo .)com \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=roopa@nvidia$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
--cc=tobias@waldekranz$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox