* Re: [PATCH net v2] net: wwan: iosm: fix memory leak in ipc_wwan_dellink
[not found] <20221027070206.107333-1-zhaoping.shu@mediatek.com>
@ 2022-10-27 17:46 ` Jakub Kicinski
0 siblings, 0 replies; only message in thread
From: Jakub Kicinski @ 2022-10-27 17:46 UTC (permalink / raw)
To: zhaoping.shu, John 'Warthog9' Hawley
Cc: m.chetan.kumar, linuxwwan, loic.poulain, ryazanov.s.a, johannes,
davem, edumazet, pabeni, netdev, linux-kernel, srv_heupstream,
haijun.liu, xiayu.zhang, lambert.wang, hw . he
On Thu, 27 Oct 2022 15:02:06 +0800 zhaoping.shu wrote:
> From: hw.he <hw.he@mediatek•com>
>
> IOSM driver registers network device without setting the
> needs_free_netdev flag, and does NOT call free_netdev() when
> unregisters network device, which causes a memory leak.
>
> This patch sets needs_free_netdev to true when registers
> network device, which makes netdev subsystem call free_netdev()
> automatically after unregister_netdevice().
>
> Fixes: 2a54f2c77934 ("net: iosm: net driver")
> Signed-off-by: hw.he <hw.he@mediatek•com>
> Reviewed-by: Loic Poulain <loic.poulain@linaro•org>
> Signed-off-by: zhaoping.shu <zhaoping.shu@mediatek•com>
Annoyingly the patches are still not making it to the list.
John, any hints you can gather from vger's logs? The patches
were resent 3 times with a 0 success rate.
Last time we hit this was with Gmail, but it doesn't seem like
mediatek.com is using Google Mail?
^ permalink raw reply [flat|nested] only message in thread