From: Jakub Kicinski <kuba@kernel•org>
To: Sudheer Mogilappagari <sudheer.mogilappagari@intel•com>
Cc: netdev@vger•kernel.org, mkubecek@suse•cz, andrew@lunn•ch,
sridhar.samudrala@intel•com, anthony.l.nguyen@intel•com
Subject: Re: [PATCH ethtool-next v5 2/2] netlink: add netlink handler for get rss (-x)
Date: Tue, 10 Jan 2023 17:54:30 -0800 [thread overview]
Message-ID: <20230110175430.19b593ec@kernel.org> (raw)
In-Reply-To: <20230110045245.3571556-3-sudheer.mogilappagari@intel.com>
LGTM! Couple of nit picks
On Mon, 9 Jan 2023 20:52:45 -0800 Sudheer Mogilappagari wrote:
> + if (hfunc) {
> + for (i = 0; i < get_count(hash_funcs); i++) {
> + if (hfunc & (1 << i))
> + print_string(PRINT_JSON, "rss-hash-function",
> + NULL, get_string(hash_funcs, i));
break?
> + }
> + }
> + ret = nlsock_process_reply(nlctx->ethnl2_socket, get_channels_cb, args);
> +
> + if (ret < 0)
> + return MNL_CB_ERROR;
no empty lines between function call and the error check
prev parent reply other threads:[~2023-01-11 1:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 4:52 [PATCH ethtool-next v5 0/2] add netlink support for rss get Sudheer Mogilappagari
2023-01-10 4:52 ` [PATCH ethtool-next v5 1/2] Move code that print rss info into common file Sudheer Mogilappagari
2023-01-10 4:52 ` [PATCH ethtool-next v5 2/2] netlink: add netlink handler for get rss (-x) Sudheer Mogilappagari
2023-01-11 1:54 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110175430.19b593ec@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sridhar.samudrala@intel$(echo .)com \
--cc=sudheer.mogilappagari@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox