From: Oz Shlomo <ozsh@nvidia•com>
To: <netdev@vger•kernel.org>
Cc: Saeed Mahameed <saeedm@nvidia•com>, Roi Dayan <roid@nvidia•com>,
"Jiri Pirko" <jiri@nvidia•com>,
Marcelo Ricardo Leitner <mleitner@redhat•com>,
"Simon Horman" <simon.horman@corigine•com>,
Baowen Zheng <baowen.zheng@corigine•com>,
Jamal Hadi Salim <jhs@mojatatu•com>,
Edward Cree <ecree.xilinx@gmail•com>,
"Oz Shlomo" <ozsh@nvidia•com>
Subject: [PATCH net-next v3 2/9] net/sched: act_pedit, setup offload action for action stats query
Date: Mon, 6 Feb 2023 15:54:35 +0200 [thread overview]
Message-ID: <20230206135442.15671-3-ozsh@nvidia.com> (raw)
In-Reply-To: <20230206135442.15671-1-ozsh@nvidia.com>
A single tc pedit action may be translated to multiple flow_offload
actions.
Offload only actions that translate to a single pedit command value.
Signed-off-by: Oz Shlomo <ozsh@nvidia•com>
---
Change log:
V1 -> V2:
- Add extack message on error
- Assign the flow action id outside the for loop.
Ensure the rest of the pedit actions follow the assigned id.
V2 -> V3:
- Fix last_cmd initialization
---
net/sched/act_pedit.c | 27 ++++++++++++++++++++++++++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c
index c42fcc47dd6d..924beb76f5b7 100644
--- a/net/sched/act_pedit.c
+++ b/net/sched/act_pedit.c
@@ -545,7 +545,32 @@ static int tcf_pedit_offload_act_setup(struct tc_action *act, void *entry_data,
}
*index_inc = k;
} else {
- return -EOPNOTSUPP;
+ struct flow_offload_action *fl_action = entry_data;
+ u32 cmd = tcf_pedit_cmd(act, 0);
+ u32 last_cmd;
+ int k;
+
+ switch (cmd) {
+ case TCA_PEDIT_KEY_EX_CMD_SET:
+ fl_action->id = FLOW_ACTION_MANGLE;
+ break;
+ case TCA_PEDIT_KEY_EX_CMD_ADD:
+ fl_action->id = FLOW_ACTION_ADD;
+ break;
+ default:
+ NL_SET_ERR_MSG_MOD(extack, "Unsupported pedit command offload");
+ return -EOPNOTSUPP;
+ }
+
+ for (k = 1; k < tcf_pedit_nkeys(act); k++) {
+ last_cmd = cmd;
+ cmd = tcf_pedit_cmd(act, k);
+
+ if (cmd != last_cmd) {
+ NL_SET_ERR_MSG_MOD(extack, "Unsupported pedit command offload");
+ return -EOPNOTSUPP;
+ }
+ }
}
return 0;
--
1.8.3.1
next prev parent reply other threads:[~2023-02-06 14:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 13:54 [PATCH net-next v3 0/9] add support for per action hw stats Oz Shlomo
2023-02-06 13:54 ` [PATCH net-next v3 1/9] net/sched: optimize action stats api calls Oz Shlomo
2023-02-10 2:31 ` Marcelo Ricardo Leitner
2023-02-06 13:54 ` Oz Shlomo [this message]
2023-02-06 14:17 ` [PATCH net-next v3 2/9] net/sched: act_pedit, setup offload action for action stats query Simon Horman
2023-02-10 2:31 ` Marcelo Ricardo Leitner
2023-02-10 6:19 ` Jakub Kicinski
2023-02-12 11:33 ` Oz Shlomo
2023-02-06 13:54 ` [PATCH net-next v3 3/9] net/sched: pass flow_stats instead of multiple stats args Oz Shlomo
2023-02-10 2:32 ` Marcelo Ricardo Leitner
2023-02-06 13:54 ` [PATCH net-next v3 4/9] net/sched: introduce flow_offload action cookie Oz Shlomo
2023-02-10 2:32 ` Marcelo Ricardo Leitner
2023-02-06 13:54 ` [PATCH net-next v3 5/9] net/sched: support per action hw stats Oz Shlomo
2023-02-10 2:32 ` Marcelo Ricardo Leitner
2023-02-06 13:54 ` [PATCH net-next v3 6/9] net/mlx5e: TC, add hw counter to branching actions Oz Shlomo
2023-02-06 13:54 ` [PATCH net-next v3 7/9] net/mlx5e: TC, store tc action cookies per attr Oz Shlomo
2023-02-06 13:54 ` [PATCH net-next v3 8/9] net/mlx5e: TC, map tc action cookie to a hw counter Oz Shlomo
2023-02-06 13:54 ` [PATCH net-next v3 9/9] net/mlx5e: TC, support per action stats Oz Shlomo
2023-02-08 5:29 ` [PATCH net-next v3 0/9] add support for per action hw stats Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230206135442.15671-3-ozsh@nvidia.com \
--to=ozsh@nvidia$(echo .)com \
--cc=baowen.zheng@corigine$(echo .)com \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@nvidia$(echo .)com \
--cc=mleitner@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roid@nvidia$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox