From: Oz Shlomo <ozsh@nvidia•com>
To: <netdev@vger•kernel.org>
Cc: Saeed Mahameed <saeedm@nvidia•com>, Roi Dayan <roid@nvidia•com>,
"Jiri Pirko" <jiri@nvidia•com>,
Marcelo Ricardo Leitner <mleitner@redhat•com>,
"Simon Horman" <simon.horman@corigine•com>,
Baowen Zheng <baowen.zheng@corigine•com>,
Jamal Hadi Salim <jhs@mojatatu•com>,
Edward Cree <ecree.xilinx@gmail•com>,
"Oz Shlomo" <ozsh@nvidia•com>
Subject: [PATCH net-next v3 6/9] net/mlx5e: TC, add hw counter to branching actions
Date: Mon, 6 Feb 2023 15:54:39 +0200 [thread overview]
Message-ID: <20230206135442.15671-7-ozsh@nvidia.com> (raw)
In-Reply-To: <20230206135442.15671-1-ozsh@nvidia.com>
Currently a hw count action is appended to the last action of the action
list. However, a branching action may terminate the action list before
reaching the last action.
Append a count action to a branching action.
In the next patches, filters with branching actions will read this counter
when reporting stats per action.
Signed-off-by: Oz Shlomo <ozsh@nvidia•com>
Reviewed-by: Roi Dayan <roid@nvidia•com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index 4e6f5caf8ab6..39f75f7d5c8b 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -3796,6 +3796,7 @@ bool mlx5e_same_hw_devs(struct mlx5e_priv *priv, struct mlx5e_priv *peer_priv)
INIT_LIST_HEAD(&attr2->list);
parse_attr->filter_dev = attr->parse_attr->filter_dev;
attr2->action = 0;
+ attr2->counter = NULL;
attr2->flags = 0;
attr2->parse_attr = parse_attr;
attr2->dest_chain = 0;
@@ -4095,6 +4096,10 @@ struct mlx5_flow_attr *
jump_state->jumping_attr = attr->branch_false;
jump_state->jump_count = jump_count;
+
+ /* branching action requires its own counter */
+ attr->action |= MLX5_FLOW_CONTEXT_ACTION_COUNT;
+
return 0;
err_branch_false:
--
1.8.3.1
next prev parent reply other threads:[~2023-02-06 14:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 13:54 [PATCH net-next v3 0/9] add support for per action hw stats Oz Shlomo
2023-02-06 13:54 ` [PATCH net-next v3 1/9] net/sched: optimize action stats api calls Oz Shlomo
2023-02-10 2:31 ` Marcelo Ricardo Leitner
2023-02-06 13:54 ` [PATCH net-next v3 2/9] net/sched: act_pedit, setup offload action for action stats query Oz Shlomo
2023-02-06 14:17 ` Simon Horman
2023-02-10 2:31 ` Marcelo Ricardo Leitner
2023-02-10 6:19 ` Jakub Kicinski
2023-02-12 11:33 ` Oz Shlomo
2023-02-06 13:54 ` [PATCH net-next v3 3/9] net/sched: pass flow_stats instead of multiple stats args Oz Shlomo
2023-02-10 2:32 ` Marcelo Ricardo Leitner
2023-02-06 13:54 ` [PATCH net-next v3 4/9] net/sched: introduce flow_offload action cookie Oz Shlomo
2023-02-10 2:32 ` Marcelo Ricardo Leitner
2023-02-06 13:54 ` [PATCH net-next v3 5/9] net/sched: support per action hw stats Oz Shlomo
2023-02-10 2:32 ` Marcelo Ricardo Leitner
2023-02-06 13:54 ` Oz Shlomo [this message]
2023-02-06 13:54 ` [PATCH net-next v3 7/9] net/mlx5e: TC, store tc action cookies per attr Oz Shlomo
2023-02-06 13:54 ` [PATCH net-next v3 8/9] net/mlx5e: TC, map tc action cookie to a hw counter Oz Shlomo
2023-02-06 13:54 ` [PATCH net-next v3 9/9] net/mlx5e: TC, support per action stats Oz Shlomo
2023-02-08 5:29 ` [PATCH net-next v3 0/9] add support for per action hw stats Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230206135442.15671-7-ozsh@nvidia.com \
--to=ozsh@nvidia$(echo .)com \
--cc=baowen.zheng@corigine$(echo .)com \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@nvidia$(echo .)com \
--cc=mleitner@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roid@nvidia$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox