From: "Hans J. Schultz" <netdev@kapio-technology•com>
To: davem@davemloft•net, kuba@kernel•org
Cc: netdev@vger•kernel.org,
"Hans J. Schultz" <netdev@kapio-technology•com>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Andrew Lunn" <andrew@lunn•ch>,
"Vladimir Oltean" <olteanv@gmail•com>,
"Eric Dumazet" <edumazet@google•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Kurt Kanzenbach" <kurt@linutronix•de>,
"Hauke Mehrtens" <hauke@hauke-m•de>,
"Woojung Huh" <woojung.huh@microchip•com>,
UNGLinuxDriver@microchip•com (maintainer:MICROCHIP KSZ SERIES
ETHERNET SWITCH DRIVER), "Sean Wang" <sean.wang@mediatek•com>,
"Landen Chao" <Landen.Chao@mediatek•com>,
"DENG Qingfang" <dqfext@gmail•com>,
"Matthias Brugger" <matthias.bgg@gmail•com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora•com>,
"Claudiu Manoil" <claudiu.manoil@nxp•com>,
"Alexandre Belloni" <alexandre.belloni@bootlin•com>,
"Clément Léger" <clement.leger@bootlin•com>,
"Jiri Pirko" <jiri@resnulli•us>,
"Ivan Vecera" <ivecera@redhat•com>,
"Roopa Prabhu" <roopa@nvidia•com>,
"Nikolay Aleksandrov" <razor@blackwall•org>,
"Shuah Khan" <shuah@kernel•org>,
"Christian Marangi" <ansuelsmth@gmail•com>,
"Ido Schimmel" <idosch@nvidia•com>,
linux-kernel@vger•kernel.org (open list),
linux-arm-kernel@lists•infradead.org (moderated
list:ARM/Mediatek SoC support),
linux-mediatek@lists•infradead.org (moderated list:ARM/Mediatek
SoC support),
linux-renesas-soc@vger•kernel.org (open list:RENESAS RZ/N1 A5PSW
SWITCH DRIVER),
bridge@lists•linux-foundation.org (moderated list:ETHERNET
BRIDGE),
linux-kselftest@vger•kernel.org (open list:KERNEL SELFTEST
FRAMEWORK)
Subject: [PATCH v2 net-next 4/6] net: bridge: ensure FDB offloaded flag is handled as needed
Date: Sat, 18 Mar 2023 15:10:08 +0100 [thread overview]
Message-ID: <20230318141010.513424-5-netdev@kapio-technology.com> (raw)
In-Reply-To: <20230318141010.513424-1-netdev@kapio-technology.com>
Since user added entries in the bridge FDB will get the BR_FDB_OFFLOADED
flag set, we do not want the bridge to age those entries and we want the
entries to be deleted in the bridge upon an SWITCHDEV_FDB_DEL_TO_BRIDGE
event.
Signed-off-by: Hans J. Schultz <netdev@kapio-technology•com>
---
net/bridge/br_fdb.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index e69a872bfc1d..b0c23a72bc76 100644
--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c
@@ -537,6 +537,7 @@ void br_fdb_cleanup(struct work_struct *work)
unsigned long this_timer = f->updated + delay;
if (test_bit(BR_FDB_STATIC, &f->flags) ||
+ test_bit(BR_FDB_OFFLOADED, &f->flags) ||
test_bit(BR_FDB_ADDED_BY_EXT_LEARN, &f->flags)) {
if (test_bit(BR_FDB_NOTIFY, &f->flags)) {
if (time_after(this_timer, now))
@@ -1465,7 +1466,9 @@ int br_fdb_external_learn_del(struct net_bridge *br, struct net_bridge_port *p,
spin_lock_bh(&br->hash_lock);
fdb = br_fdb_find(br, addr, vid);
- if (fdb && test_bit(BR_FDB_ADDED_BY_EXT_LEARN, &fdb->flags))
+ if (fdb &&
+ (test_bit(BR_FDB_ADDED_BY_EXT_LEARN, &fdb->flags) ||
+ test_bit(BR_FDB_OFFLOADED, &fdb->flags)))
fdb_delete(br, fdb, swdev_notify);
else
err = -ENOENT;
--
2.34.1
next prev parent reply other threads:[~2023-03-18 14:25 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 14:10 [PATCH v2 net-next 0/6] ATU and FDB synchronization on locked ports Hans J. Schultz
2023-03-18 14:10 ` [PATCH v2 net-next 1/6] net: bridge: add dynamic flag to switchdev notifier Hans J. Schultz
2023-03-20 8:48 ` Ido Schimmel
2023-03-24 13:04 ` Hans Schultz
2023-03-18 14:10 ` [PATCH v2 net-next 2/6] net: dsa: propagate flags down towards drivers Hans J. Schultz
2023-03-27 11:52 ` Vladimir Oltean
2023-03-27 15:31 ` Hans Schultz
2023-03-27 16:00 ` Vladimir Oltean
2023-03-27 21:49 ` Hans Schultz
2023-03-27 22:59 ` Vladimir Oltean
2023-03-28 11:04 ` Hans Schultz
2023-03-28 11:49 ` Vladimir Oltean
2023-03-28 19:45 ` Hans Schultz
2023-03-30 12:43 ` Vladimir Oltean
2023-03-30 12:59 ` Hans Schultz
2023-03-30 13:09 ` Vladimir Oltean
2023-03-30 14:54 ` Hans Schultz
2023-03-30 15:07 ` Vladimir Oltean
2023-03-30 15:34 ` Hans Schultz
2023-03-30 15:44 ` Vladimir Oltean
2023-04-06 15:17 ` Hans Schultz
2023-04-06 15:21 ` Vladimir Oltean
2023-04-06 16:20 ` Hans Schultz
2023-03-18 14:10 ` [PATCH v2 net-next 3/6] drivers: net: dsa: add fdb entry flags incoming to switchcore drivers Hans J. Schultz
2023-03-18 14:10 ` Hans J. Schultz [this message]
2023-03-18 14:10 ` [PATCH v2 net-next 5/6] net: dsa: mv88e6xxx: implementation of dynamic ATU entries Hans J. Schultz
2023-03-18 14:10 ` [PATCH v2 net-next 6/6] selftests: forwarding: add dynamic FDB test Hans J. Schultz
2023-03-20 8:44 ` Ido Schimmel
2023-03-26 15:41 ` Hans Schultz
2023-03-28 16:40 ` Ido Schimmel
2023-03-28 19:30 ` Hans Schultz
2023-03-30 6:37 ` Ido Schimmel
2023-03-30 10:29 ` Hans Schultz
2023-03-30 10:45 ` Nikolay Aleksandrov
2023-03-30 19:07 ` Hans Schultz
2023-03-30 19:27 ` Vladimir Oltean
2023-03-31 7:43 ` Hans Schultz
2023-03-31 8:58 ` Vladimir Oltean
2023-03-31 8:06 ` Hans Schultz
2023-03-31 9:37 ` Vladimir Oltean
2023-03-31 12:43 ` Hans Schultz
2023-04-06 15:24 ` Vladimir Oltean
2023-04-06 16:26 ` Hans Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230318141010.513424-5-netdev@kapio-technology.com \
--to=netdev@kapio-technology$(echo .)com \
--cc=Landen.Chao@mediatek$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=ansuelsmth@gmail$(echo .)com \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=clement.leger@bootlin$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dqfext@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hauke@hauke-m$(echo .)de \
--cc=idosch@nvidia$(echo .)com \
--cc=ivecera@redhat$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=kurt@linutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=roopa@nvidia$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
--cc=shuah@kernel$(echo .)org \
--cc=woojung.huh@microchip$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox