From: Hans Schultz <netdev@kapio-technology•com>
To: Ido Schimmel <idosch@nvidia•com>
Cc: davem@davemloft•net, kuba@kernel•org, netdev@vger•kernel.org,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Andrew Lunn" <andrew@lunn•ch>,
"Vladimir Oltean" <olteanv@gmail•com>,
"Eric Dumazet" <edumazet@google•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Kurt Kanzenbach" <kurt@linutronix•de>,
"Hauke Mehrtens" <hauke@hauke-m•de>,
"Woojung Huh" <woojung.huh@microchip•com>,
"maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER"
<UNGLinuxDriver@microchip•com>,
"Sean Wang" <sean.wang@mediatek•com>,
"Landen Chao" <Landen.Chao@mediatek•com>,
"DENG Qingfang" <dqfext@gmail•com>,
"Matthias Brugger" <matthias.bgg@gmail•com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora•com>,
"Claudiu Manoil" <claudiu.manoil@nxp•com>,
"Alexandre Belloni" <alexandre.belloni@bootlin•com>,
"Clément Léger" <clement.leger@bootlin•com>,
"Jiri Pirko" <jiri@resnulli•us>,
"Ivan Vecera" <ivecera@redhat•com>,
"Roopa Prabhu" <roopa@nvidia•com>,
"Nikolay Aleksandrov" <razor@blackwall•org>,
"Shuah Khan" <shuah@kernel•org>,
"Christian Marangi" <ansuelsmth@gmail•com>,
"open list" <linux-kernel@vger•kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists•infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists•infradead.org>,
"open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER"
<linux-renesas-soc@vger•kernel.org>,
"moderated list:ETHERNET BRIDGE"
<bridge@lists•linux-foundation.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger•kernel.org>
Subject: Re: [PATCH v2 net-next 6/6] selftests: forwarding: add dynamic FDB test
Date: Thu, 30 Mar 2023 21:07:53 +0200 [thread overview]
Message-ID: <874jq22h2u.fsf@kapio-technology.com> (raw)
In-Reply-To: <ZCMYbRqd+qZaiHfu@shredder>
On Tue, Mar 28, 2023 at 19:40, Ido Schimmel <idosch@nvidia•com> wrote:
> On Sun, Mar 26, 2023 at 05:41:06PM +0200, Hans Schultz wrote:
>> On Mon, Mar 20, 2023 at 10:44, Ido Schimmel <idosch@nvidia•com> wrote:
>> >> + $MZ $swp1 -c 1 -p 128 -t udp "sp=54321,dp=12345" \
>> >> + -a $mac -b `mac_get $h2` -A 192.0.2.1 -B 192.0.2.2 -q
>> >> + tc_check_packets "dev $swp2 egress" 1 1
>> >> + check_fail $? "Dynamic FDB entry did not age out"
>> >
>> > Shouldn't this be check_err()? After the FDB entry was aged you want to
>> > make sure that packets received via $swp1 with SMAC being $mac are no
>> > longer forwarded by the bridge.
>>
>> I was thinking that check_fail() will pass when tc_check_packets() does
>> not see any packets, thus the test passing here when no packets are forwarded?
>
> What do you mean by "I was *thinking*"? How is it possible that you are
> submitting a selftest that you didn't bother running?!
>
> I see you trimmed my earlier question: "Does this actually work?"
>
> I tried it and it passed:
>
> # ./bridge_locked_port.sh
> TEST: Locked port ipv4 [ OK ]
> TEST: Locked port ipv6 [ OK ]
> TEST: Locked port vlan [ OK ]
> TEST: Locked port MAB [ OK ]
> TEST: Locked port MAB roam [ OK ]
> TEST: Locked port MAB configuration [ OK ]
> TEST: Locked port MAB FDB flush [ OK ]
>
> And I couldn't understand how that's even possible. Then I realized that
> the entire test is dead code because the patch is missing this
> fundamental hunk:
>
> ```
> diff --git a/tools/testing/selftests/net/forwarding/bridge_locked_port.sh b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
> index dbc7017fd45d..5bf6b2aa1098 100755
> --- a/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
> +++ b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
> @@ -9,6 +9,7 @@ ALL_TESTS="
> locked_port_mab_roam
> locked_port_mab_config
> locked_port_mab_flush
> + locked_port_dyn_fdb
> "
>
> NUM_NETIFS=4
> ```
>
> Which tells me that you didn't even try running it once.
Not true, it reveals that I forgot to put it in the patch, that's all. As
I cannot run several of these tests because of memory constraints I link
the file to a copy in a rw area where I modify the list and just run one
of the subtests at a time. If I try to run the whole it always fails
after a couple of sub-tests with an error.
It seems to me that these scripts are quite memory consuming as they
accumulate memory consuption in relation to what is loaded along the
way. A major problem with my system.
next prev parent reply other threads:[~2023-03-30 19:10 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 14:10 [PATCH v2 net-next 0/6] ATU and FDB synchronization on locked ports Hans J. Schultz
2023-03-18 14:10 ` [PATCH v2 net-next 1/6] net: bridge: add dynamic flag to switchdev notifier Hans J. Schultz
2023-03-20 8:48 ` Ido Schimmel
2023-03-24 13:04 ` Hans Schultz
2023-03-18 14:10 ` [PATCH v2 net-next 2/6] net: dsa: propagate flags down towards drivers Hans J. Schultz
2023-03-27 11:52 ` Vladimir Oltean
2023-03-27 15:31 ` Hans Schultz
2023-03-27 16:00 ` Vladimir Oltean
2023-03-27 21:49 ` Hans Schultz
2023-03-27 22:59 ` Vladimir Oltean
2023-03-28 11:04 ` Hans Schultz
2023-03-28 11:49 ` Vladimir Oltean
2023-03-28 19:45 ` Hans Schultz
2023-03-30 12:43 ` Vladimir Oltean
2023-03-30 12:59 ` Hans Schultz
2023-03-30 13:09 ` Vladimir Oltean
2023-03-30 14:54 ` Hans Schultz
2023-03-30 15:07 ` Vladimir Oltean
2023-03-30 15:34 ` Hans Schultz
2023-03-30 15:44 ` Vladimir Oltean
2023-04-06 15:17 ` Hans Schultz
2023-04-06 15:21 ` Vladimir Oltean
2023-04-06 16:20 ` Hans Schultz
2023-03-18 14:10 ` [PATCH v2 net-next 3/6] drivers: net: dsa: add fdb entry flags incoming to switchcore drivers Hans J. Schultz
2023-03-18 14:10 ` [PATCH v2 net-next 4/6] net: bridge: ensure FDB offloaded flag is handled as needed Hans J. Schultz
2023-03-18 14:10 ` [PATCH v2 net-next 5/6] net: dsa: mv88e6xxx: implementation of dynamic ATU entries Hans J. Schultz
2023-03-18 14:10 ` [PATCH v2 net-next 6/6] selftests: forwarding: add dynamic FDB test Hans J. Schultz
2023-03-20 8:44 ` Ido Schimmel
2023-03-26 15:41 ` Hans Schultz
2023-03-28 16:40 ` Ido Schimmel
2023-03-28 19:30 ` Hans Schultz
2023-03-30 6:37 ` Ido Schimmel
2023-03-30 10:29 ` Hans Schultz
2023-03-30 10:45 ` Nikolay Aleksandrov
2023-03-30 19:07 ` Hans Schultz [this message]
2023-03-30 19:27 ` Vladimir Oltean
2023-03-31 7:43 ` Hans Schultz
2023-03-31 8:58 ` Vladimir Oltean
2023-03-31 8:06 ` Hans Schultz
2023-03-31 9:37 ` Vladimir Oltean
2023-03-31 12:43 ` Hans Schultz
2023-04-06 15:24 ` Vladimir Oltean
2023-04-06 16:26 ` Hans Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jq22h2u.fsf@kapio-technology.com \
--to=netdev@kapio-technology$(echo .)com \
--cc=Landen.Chao@mediatek$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=ansuelsmth@gmail$(echo .)com \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=clement.leger@bootlin$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dqfext@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hauke@hauke-m$(echo .)de \
--cc=idosch@nvidia$(echo .)com \
--cc=ivecera@redhat$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=kurt@linutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=roopa@nvidia$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
--cc=shuah@kernel$(echo .)org \
--cc=woojung.huh@microchip$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox