From: Jakub Kicinski <kuba@kernel•org>
To: Donald Hunter <donald.hunter@gmail•com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
donald.hunter@redhat•com
Subject: Re: [PATCH net-next v2 4/6] tools: ynl: Add struct attr decoding to ynl
Date: Wed, 22 Mar 2023 11:37:59 -0700 [thread overview]
Message-ID: <20230322113759.71d44e97@kernel.org> (raw)
In-Reply-To: <m27cv9j9c3.fsf@gmail.com>
On Wed, 22 Mar 2023 11:48:12 +0000 Donald Hunter wrote:
> > On Sun, 19 Mar 2023 19:38:01 +0000 Donald Hunter wrote:
> >> enum: [ unused, pad, flag, binary, u8, u16, u32, u64, s32, s64,
> >> - string, nest, array-nest, nest-type-value ]
> >> + string, nest, array-nest, nest-type-value, struct ]
> >
> > I wonder if we should also only allow struct as a subtype of binary?
> >
> > Structs can technically grow with newer kernels (i.e. new members can
> > be added at the end). So I think for languages like C we will still
> > need to expose to the user the original length of the attribute.
> > And binary comes with a length so codgen reuse fits nicely.
> >
> > Either way - docs need to be updated.
>
> Yep, as I was replying to your previous comment, I started to think
> about making struct a subtype of binary. That would make a struct attr
> something like:
>
> -
> name: stats
> type: binary
> sub-type: struct
> struct: vport-stats
LGTM!
> I originally chose 'struct' as the attr name, following the pattern that
> 'enum' is used for enum names but I'm not sure it's clear enough. Maybe
> 'sub-type-name' would be better?
Agreed, using the sub-type's value as name of another attr
is mixing keys and values.
But sub-type-name would then also be used for enums (I mean in
normal type: u32 enums, not binary arrays)?
enums don't have a sub-type so there we'd have sub-type-name
and no sub-type.
Plus for binary arrays of enums we'd have:
-
name: stats
type: binary
sub-type: u32
sub-type-name: vport-stats
Doesn't say enum anywhere :S We'd need to assume if sub-type is
a scalar the sub-type-name is an enum?
Maybe to avoid saying struct twice we should go the enum way and
actually ditch the sub-type for structs? Presence of struct: abc
implies it's a struct, only use sub-type for scalar types?
-
name: stats
type: binary
struct: vport-stats
-
name: another
type: binary
sub-type: u32
enum: enums-name
next prev parent reply other threads:[~2023-03-22 18:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 19:37 [PATCH net-next v2 0/6] ynl: add support for user headers and struct attrs Donald Hunter
2023-03-19 19:37 ` [PATCH net-next v2 1/6] tools: ynl: Fix genlmsg header encoding formats Donald Hunter
2023-03-19 19:37 ` [PATCH net-next v2 2/6] tools: ynl: Add struct parsing to nlspec Donald Hunter
2023-03-22 5:22 ` Jakub Kicinski
2023-03-22 11:38 ` Donald Hunter
2023-03-22 18:25 ` Jakub Kicinski
2023-03-19 19:38 ` [PATCH net-next v2 3/6] tools: ynl: Add array-nest attr decoding to ynl Donald Hunter
2023-03-22 5:18 ` Jakub Kicinski
2023-03-22 11:27 ` Donald Hunter
2023-03-22 18:27 ` Jakub Kicinski
2023-03-19 19:38 ` [PATCH net-next v2 4/6] tools: ynl: Add struct " Donald Hunter
2023-03-22 5:30 ` Jakub Kicinski
2023-03-22 11:48 ` Donald Hunter
2023-03-22 18:37 ` Jakub Kicinski [this message]
2023-03-22 22:06 ` Donald Hunter
2023-03-19 19:38 ` [PATCH net-next v2 5/6] tools: ynl: Add fixed-header support " Donald Hunter
2023-03-22 5:34 ` Jakub Kicinski
2023-03-22 11:54 ` Donald Hunter
2023-03-19 19:38 ` [PATCH net-next v2 6/6] netlink: specs: add partial specification for openvswitch Donald Hunter
2023-03-23 3:50 ` [PATCH net-next v2 0/6] ynl: add support for user headers and struct attrs patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322113759.71d44e97@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=donald.hunter@redhat$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox