From: Jakub Kicinski <kuba@kernel•org>
To: Alex Berliner <alexberliner@google•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net,
Jeroen de Borst <jeroendb@google•com>,
Willem de Bruijn <willemb@google•com>
Subject: Re: [PATCH net-next] gve: Add modify ring size support
Date: Wed, 19 Apr 2023 15:48:50 -0700 [thread overview]
Message-ID: <20230419154850.5fec4c1d@kernel.org> (raw)
In-Reply-To: <20230418221313.39112-1-alexberliner@google.com>
On Tue, 18 Apr 2023 22:13:13 +0000 Alex Berliner wrote:
> + err = gve_close(priv->dev);
> + if (err)
> + return err;
> + priv->tx_desc_cnt = new_tx_desc_cnt;
> + priv->rx_desc_cnt = new_rx_desc_cnt;
> +
> + err = gve_open(priv->dev);
> + if (err)
> + goto err;
please don't close / open. if the machine is low on memory it will
fall off the network. I think I had a similar complaint about xdp
patches for gve, it'd be great if people working on gve within google
talked to each other.
prev parent reply other threads:[~2023-04-19 22:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 22:13 [PATCH net-next] gve: Add modify ring size support Alex Berliner
2023-04-19 10:30 ` Pavan Chebbi
2023-04-19 22:48 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230419154850.5fec4c1d@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=alexberliner@google$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jeroendb@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox