From: Jakub Kicinski <kuba@kernel•org>
To: Simon Horman <simon.horman@corigine•com>
Cc: Christian Brauner <brauner@kernel•org>,
kernel test robot <lkp@intel•com>,
Eric Dumazet <edumazet@google•com>,
Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical•com>,
davem@davemloft•net, oe-kbuild-all@lists•linux.dev,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
Paolo Abeni <pabeni@redhat•com>,
Leon Romanovsky <leon@kernel•org>,
David Ahern <dsahern@kernel•org>, Arnd Bergmann <arnd@arndb•de>,
Kees Cook <keescook@chromium•org>,
Kuniyuki Iwashima <kuniyu@amazon•com>,
Lennart Poettering <mzxreary@0pointer•de>,
Luca Boccassi <bluca@debian•org>,
linux-arch@vger•kernel.org
Subject: Re: [PATCH net-next v5 1/3] scm: add SO_PASSPIDFD and SCM_PIDFD
Date: Mon, 22 May 2023 13:12:52 -0700 [thread overview]
Message-ID: <20230522131252.4f9959d3@kernel.org> (raw)
In-Reply-To: <ZGtr1RwK42We5ACI@corigine.com>
On Mon, 22 May 2023 15:19:17 +0200 Simon Horman wrote:
> > TLI, that AF_UNIX can be a kernel module...
> > I'm really not excited in exposing pidfd_prepare() to non-core kernel
> > code. Would it be possible to please simply refuse SO_PEERPIDFD and
> > SCM_PIDFD if AF_UNIX is compiled as a module? I feel that this must be
> > super rare because it risks breaking even simplistic userspace.
>
> It occurs to me that it may be simpler to not allow AF_UNIX to be a module.
> But perhaps that breaks something for someone...
Both of the two options (disable the feature with unix=m, make unix
bool) could lead to breakage, I reckon at least the latter makes
the breakage more obvious? So not allowing AF_UNIX as a module
gets my vote as well.
A mechanism of exporting symbols for core/internal use only would
find a lot of use in networking :(
next prev parent reply other threads:[~2023-05-22 20:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 11:33 [PATCH net-next v5 0/3] Add SCM_PIDFD and SO_PEERPIDFD Alexander Mikhalitsyn
2023-05-17 11:33 ` [PATCH net-next v5 1/3] scm: add SO_PASSPIDFD and SCM_PIDFD Alexander Mikhalitsyn
2023-05-19 11:02 ` Christian Brauner
2023-05-20 14:11 ` kernel test robot
2023-05-22 9:47 ` Christian Brauner
2023-05-22 13:19 ` Simon Horman
2023-05-22 20:12 ` Jakub Kicinski [this message]
2023-05-22 20:17 ` Luca Boccassi
2023-05-23 8:53 ` Simon Horman
2023-05-17 11:33 ` [PATCH net-next v5 2/3] net: core: add getsockopt SO_PEERPIDFD Alexander Mikhalitsyn
2023-05-19 11:03 ` Christian Brauner
2023-05-22 17:12 ` Stanislav Fomichev
2023-05-17 11:33 ` [PATCH net-next v5 3/3] selftests: net: add SCM_PIDFD / SO_PEERPIDFD test Alexander Mikhalitsyn
2023-05-19 11:04 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522131252.4f9959d3@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=aleksandr.mikhalitsyn@canonical$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=bluca@debian$(echo .)org \
--cc=brauner@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kuniyu@amazon$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lkp@intel$(echo .)com \
--cc=mzxreary@0pointer$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oe-kbuild-all@lists$(echo .)linux.dev \
--cc=pabeni@redhat$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox