From: Simon Horman <simon.horman@corigine•com>
To: Christian Brauner <brauner@kernel•org>
Cc: kernel test robot <lkp@intel•com>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>,
Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical•com>,
davem@davemloft•net, oe-kbuild-all@lists•linux.dev,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
Paolo Abeni <pabeni@redhat•com>,
Leon Romanovsky <leon@kernel•org>,
David Ahern <dsahern@kernel•org>, Arnd Bergmann <arnd@arndb•de>,
Kees Cook <keescook@chromium•org>,
Kuniyuki Iwashima <kuniyu@amazon•com>,
Lennart Poettering <mzxreary@0pointer•de>,
Luca Boccassi <bluca@debian•org>,
linux-arch@vger•kernel.org
Subject: Re: [PATCH net-next v5 1/3] scm: add SO_PASSPIDFD and SCM_PIDFD
Date: Mon, 22 May 2023 15:19:17 +0200 [thread overview]
Message-ID: <ZGtr1RwK42We5ACI@corigine.com> (raw)
In-Reply-To: <20230522-sammeln-neumond-e9a8d196056b@brauner>
On Mon, May 22, 2023 at 11:47:08AM +0200, Christian Brauner wrote:
> On Sat, May 20, 2023 at 10:11:36PM +0800, kernel test robot wrote:
> > Hi Alexander,
> >
> > kernel test robot noticed the following build errors:
> >
> > [auto build test ERROR on net-next/main]
> >
> > url: https://github.com/intel-lab-lkp/linux/commits/Alexander-Mikhalitsyn/scm-add-SO_PASSPIDFD-and-SCM_PIDFD/20230517-193620
> > base: net-next/main
> > patch link: https://lore.kernel.org/r/20230517113351.308771-2-aleksandr.mikhalitsyn%40canonical.com
> > patch subject: [PATCH net-next v5 1/3] scm: add SO_PASSPIDFD and SCM_PIDFD
> > config: powerpc-randconfig-s043-20230517
> > compiler: powerpc-linux-gcc (GCC) 12.1.0
> > reproduce:
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # apt-get install sparse
> > # sparse version: v0.6.4-39-gce1a6720-dirty
> > # https://github.com/intel-lab-lkp/linux/commit/969a57c99c9d50bfebd0908f5157870b36c271c7
> > git remote add linux-review https://github.com/intel-lab-lkp/linux
> > git fetch --no-tags linux-review Alexander-Mikhalitsyn/scm-add-SO_PASSPIDFD-and-SCM_PIDFD/20230517-193620
> > git checkout 969a57c99c9d50bfebd0908f5157870b36c271c7
> > # save the config file
> > mkdir build_dir && cp config build_dir/.config
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc olddefconfig
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc SHELL=/bin/bash
> >
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <lkp@intel•com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202305202107.BQoPnLYP-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>, old ones prefixed by <<):
> >
> > >> ERROR: modpost: "pidfd_prepare" [net/unix/unix.ko] undefined!
>
> TLI, that AF_UNIX can be a kernel module...
> I'm really not excited in exposing pidfd_prepare() to non-core kernel
> code. Would it be possible to please simply refuse SO_PEERPIDFD and
> SCM_PIDFD if AF_UNIX is compiled as a module? I feel that this must be
> super rare because it risks breaking even simplistic userspace.
It occurs to me that it may be simpler to not allow AF_UNIX to be a module.
But perhaps that breaks something for someone...
next prev parent reply other threads:[~2023-05-22 13:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 11:33 [PATCH net-next v5 0/3] Add SCM_PIDFD and SO_PEERPIDFD Alexander Mikhalitsyn
2023-05-17 11:33 ` [PATCH net-next v5 1/3] scm: add SO_PASSPIDFD and SCM_PIDFD Alexander Mikhalitsyn
2023-05-19 11:02 ` Christian Brauner
2023-05-20 14:11 ` kernel test robot
2023-05-22 9:47 ` Christian Brauner
2023-05-22 13:19 ` Simon Horman [this message]
2023-05-22 20:12 ` Jakub Kicinski
2023-05-22 20:17 ` Luca Boccassi
2023-05-23 8:53 ` Simon Horman
2023-05-17 11:33 ` [PATCH net-next v5 2/3] net: core: add getsockopt SO_PEERPIDFD Alexander Mikhalitsyn
2023-05-19 11:03 ` Christian Brauner
2023-05-22 17:12 ` Stanislav Fomichev
2023-05-17 11:33 ` [PATCH net-next v5 3/3] selftests: net: add SCM_PIDFD / SO_PEERPIDFD test Alexander Mikhalitsyn
2023-05-19 11:04 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGtr1RwK42We5ACI@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=aleksandr.mikhalitsyn@canonical$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=bluca@debian$(echo .)org \
--cc=brauner@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kuniyu@amazon$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lkp@intel$(echo .)com \
--cc=mzxreary@0pointer$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oe-kbuild-all@lists$(echo .)linux.dev \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox