From: Jakub Kicinski <kuba@kernel•org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail•com>
Cc: "Linga, Pavan Kumar" <pavan.kumar.linga@intel•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
davem@davemloft•net, pabeni@redhat•com, edumazet@google•com,
netdev@vger•kernel.org, emil.s.tantilov@intel•com,
jesse.brandeburg@intel•com, sridhar.samudrala@intel•com,
shiraz.saleem@intel•com, sindhu.devale@intel•com,
willemb@google•com, decot@google•com, andrew@lunn•ch,
leon@kernel•org, mst@redhat•com, simon.horman@corigine•com,
shannon.nelson@amd•com, stephen@networkplumber•org,
Alan Brady <alan.brady@intel•com>,
Joshua Hay <joshua.a.hay@intel•com>,
Madhu Chittim <madhu.chittim@intel•com>,
Phani Burra <phani.r.burra@intel•com>,
Shailendra Bhatnagar <shailendra.bhatnagar@intel•com>,
Krishneil Singh <krishneil.k.singh@intel•com>
Subject: Re: [PATCH net-next 05/15] idpf: add create vport and netdev configuration
Date: Wed, 7 Jun 2023 12:10:06 -0700 [thread overview]
Message-ID: <20230607121006.59d57ca0@kernel.org> (raw)
In-Reply-To: <CAF=yD-KAQceDE9UmJAvepz8tWGgqyr+drv_WYp-q=7vEEUTfiA@mail.gmail.com>
On Wed, 7 Jun 2023 20:20:57 +0200 Willem de Bruijn wrote:
> > > Please use locks. Every single Intel driver comes with gazillion flags
> > > and endless bugs when the flags go out of sync.
> >
> > Thanks for the feedback. Will use mutex lock instead of 'VC_MSG_PENDING'
> > flag.
>
> Was that the intent of the comment?
>
> Or is it to replace these individual atomic test_and_set bit
> operations with a single spinlock-protected critical section around
> all the flag operations?
No, no. Intel drivers have a history of adding flags to work around
locking problems. Whatever this bit is protecting should be protected
by a normal synchronization primitive instead.
I don't understand why.
Replacing an atomic bitop with a spin lock is a non-change.
> That's how I read the suggestion.
next prev parent reply other threads:[~2023-06-07 19:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 23:44 [PATCH net-next 00/15][pull request] Introduce Intel IDPF driver Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 01/15] virtchnl: add virtchnl version 2 ops Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 02/15] idpf: add module register and probe functionality Tony Nguyen
2023-05-31 6:05 ` Michael S. Tsirkin
2023-05-31 18:34 ` Jesse Brandeburg
2023-05-31 20:25 ` Tony Nguyen
2023-06-11 17:54 ` Leon Romanovsky
2023-05-30 23:44 ` [PATCH net-next 03/15] idpf: add controlq init and reset checks Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 04/15] idpf: add core init and interrupt request Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 05/15] idpf: add create vport and netdev configuration Tony Nguyen
2023-06-01 6:22 ` Jakub Kicinski
2023-06-01 23:47 ` Linga, Pavan Kumar
2023-06-07 18:20 ` Willem de Bruijn
2023-06-07 19:10 ` Jakub Kicinski [this message]
2023-06-07 19:39 ` Willem de Bruijn
2023-05-30 23:44 ` [PATCH net-next 06/15] idpf: continue expanding init task Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 07/15] idpf: configure resources for TX queues Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 08/15] idpf: configure resources for RX queues Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 09/15] idpf: initialize interrupts and enable vport Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 10/15] idpf: add splitq start_xmit Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 11/15] idpf: add TX splitq napi poll support Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 12/15] idpf: add RX " Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 13/15] idpf: add singleq start_xmit and napi poll Tony Nguyen
2023-05-30 23:45 ` [PATCH net-next 14/15] idpf: add ethtool callbacks Tony Nguyen
2023-05-30 23:45 ` [PATCH net-next 15/15] idpf: configure SRIOV and add other ndo_ops Tony Nguyen
2023-06-01 6:23 ` Jakub Kicinski
2023-06-01 23:40 ` Linga, Pavan Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607121006.59d57ca0@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=alan.brady@intel$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=decot@google$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=emil.s.tantilov@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=joshua.a.hay@intel$(echo .)com \
--cc=krishneil.k.singh@intel$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=madhu.chittim@intel$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.kumar.linga@intel$(echo .)com \
--cc=phani.r.burra@intel$(echo .)com \
--cc=shailendra.bhatnagar@intel$(echo .)com \
--cc=shannon.nelson@amd$(echo .)com \
--cc=shiraz.saleem@intel$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=sindhu.devale@intel$(echo .)com \
--cc=sridhar.samudrala@intel$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=willemb@google$(echo .)com \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox