From: Jakub Kicinski <kuba@kernel•org>
To: Haiyang Zhang <haiyangz@microsoft•com>
Cc: "linux-hyperv@vger•kernel.org" <linux-hyperv@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Dexuan Cui <decui@microsoft•com>,
KY Srinivasan <kys@microsoft•com>,
Paul Rosswurm <paulros@microsoft•com>,
"olaf@aepfle•de" <olaf@aepfle•de>,
"vkuznets@redhat•com" <vkuznets@redhat•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"wei.liu@kernel•org" <wei.liu@kernel•org>,
"edumazet@google•com" <edumazet@google•com>,
"pabeni@redhat•com" <pabeni@redhat•com>,
"leon@kernel•org" <leon@kernel•org>,
Long Li <longli@microsoft•com>,
"ssengar@linux•microsoft.com" <ssengar@linux•microsoft.com>,
"linux-rdma@vger•kernel.org" <linux-rdma@vger•kernel.org>,
"daniel@iogearbox•net" <daniel@iogearbox•net>,
"john.fastabend@gmail•com" <john.fastabend@gmail•com>,
"bpf@vger•kernel.org" <bpf@vger•kernel.org>,
"ast@kernel•org" <ast@kernel•org>,
Ajay Sharma <sharmaajay@microsoft•com>,
"hawk@kernel•org" <hawk@kernel•org>,
"tglx@linutronix•de" <tglx@linutronix•de>,
"shradhagupta@linux•microsoft.com"
<shradhagupta@linux•microsoft.com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH net-next] net: mana: Add page pool for RX buffers
Date: Thu, 13 Jul 2023 20:53:26 -0700 [thread overview]
Message-ID: <20230713205326.5f960907@kernel.org> (raw)
In-Reply-To: <1689259687-5231-1-git-send-email-haiyangz@microsoft.com>
On Thu, 13 Jul 2023 14:48:45 +0000 Haiyang Zhang wrote:
> Add page pool for RX buffers for faster buffer cycle and reduce CPU
> usage.
>
> Get an extra ref count of a page after allocation, so after upper
> layers put the page, it's still referenced by the pool. We can reuse
> it as RX buffer without alloc a new page.
Please use the real page_pool API from include/net/page_pool.h
We've moved past every driver reinventing the wheel, sorry.
--
pw-bot: cr
next prev parent reply other threads:[~2023-07-14 3:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 14:48 [PATCH net-next] net: mana: Add page pool for RX buffers Haiyang Zhang
2023-07-14 3:53 ` Jakub Kicinski [this message]
2023-07-14 7:43 ` Jesper Dangaard Brouer
2023-07-14 12:51 ` Haiyang Zhang
2023-07-14 13:13 ` Jesper Dangaard Brouer
2023-07-14 15:31 ` Jakub Kicinski
2023-07-17 18:26 ` Haiyang Zhang
2023-07-17 23:59 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713205326.5f960907@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=haiyangz@microsoft$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kys@microsoft$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=longli@microsoft$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olaf@aepfle$(echo .)de \
--cc=pabeni@redhat$(echo .)com \
--cc=paulros@microsoft$(echo .)com \
--cc=sharmaajay@microsoft$(echo .)com \
--cc=shradhagupta@linux$(echo .)microsoft.com \
--cc=ssengar@linux$(echo .)microsoft.com \
--cc=tglx@linutronix$(echo .)de \
--cc=vkuznets@redhat$(echo .)com \
--cc=wei.liu@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox