From: Jakub Kicinski <kuba@kernel•org>
To: Jesper Dangaard Brouer <jbrouer@redhat•com>
Cc: Haiyang Zhang <haiyangz@microsoft•com>,
brouer@redhat•com,
"linux-hyperv@vger•kernel.org" <linux-hyperv@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Dexuan Cui <decui@microsoft•com>,
KY Srinivasan <kys@microsoft•com>,
Paul Rosswurm <paulros@microsoft•com>,
"olaf@aepfle•de" <olaf@aepfle•de>,
"vkuznets@redhat•com" <vkuznets@redhat•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"wei.liu@kernel•org" <wei.liu@kernel•org>,
"edumazet@google•com" <edumazet@google•com>,
"pabeni@redhat•com" <pabeni@redhat•com>,
"leon@kernel•org" <leon@kernel•org>,
Long Li <longli@microsoft•com>,
"ssengar@linux•microsoft.com" <ssengar@linux•microsoft.com>,
"linux-rdma@vger•kernel.org" <linux-rdma@vger•kernel.org>,
"daniel@iogearbox•net" <daniel@iogearbox•net>,
"john.fastabend@gmail•com" <john.fastabend@gmail•com>,
"bpf@vger•kernel.org" <bpf@vger•kernel.org>,
"ast@kernel•org" <ast@kernel•org>,
Ajay Sharma <sharmaajay@microsoft•com>,
"hawk@kernel•org" <hawk@kernel•org>,
"tglx@linutronix•de" <tglx@linutronix•de>,
"shradhagupta@linux•microsoft.com"
<shradhagupta@linux•microsoft.com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro•org>
Subject: Re: [PATCH net-next] net: mana: Add page pool for RX buffers
Date: Fri, 14 Jul 2023 08:31:52 -0700 [thread overview]
Message-ID: <20230714083152.3f64d38a@kernel.org> (raw)
In-Reply-To: <3b043a95-a4bc-bbaf-c8e0-240e8ddea62f@redhat.com>
On Fri, 14 Jul 2023 15:13:15 +0200 Jesper Dangaard Brouer wrote:
> > Thank Jakub and Jesper for the reviews.
> > I'm aware of the page_pool.rst doc, and actually tried it before this
> > patch, but I got lower perf. If I understand correctly, we should call
> > page_pool_release_page() before passing the SKB to napi_gro_receive().
> >
> > I found the page_pool_dev_alloc_pages() goes through the slow path,
> > because the page_pool_release_page() let the page leave the pool.
> >
> > Do we have to call page_pool_release_page() before passing the SKB
> > to napi_gro_receive()? Any better way to recycle the pages from the
> > upper layer of non-XDP case?
> >
>
> Today SKB "upper layers" can recycle page_pool backed packet data/page.
>
> Just use skb_mark_for_recycle(skb), then you don't need
> page_pool_release_page().
>
> I guess, we should update the documentation, mentioning this.
Ah, I should probably send in the few cleanups form the huge page
series. It looks like all users of page_pool_release_page() can
be converted to skb recycling, so we should hide it and remove
from docs?
next prev parent reply other threads:[~2023-07-14 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 14:48 [PATCH net-next] net: mana: Add page pool for RX buffers Haiyang Zhang
2023-07-14 3:53 ` Jakub Kicinski
2023-07-14 7:43 ` Jesper Dangaard Brouer
2023-07-14 12:51 ` Haiyang Zhang
2023-07-14 13:13 ` Jesper Dangaard Brouer
2023-07-14 15:31 ` Jakub Kicinski [this message]
2023-07-17 18:26 ` Haiyang Zhang
2023-07-17 23:59 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230714083152.3f64d38a@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=brouer@redhat$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=haiyangz@microsoft$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=jbrouer@redhat$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kys@microsoft$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=longli@microsoft$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olaf@aepfle$(echo .)de \
--cc=pabeni@redhat$(echo .)com \
--cc=paulros@microsoft$(echo .)com \
--cc=sharmaajay@microsoft$(echo .)com \
--cc=shradhagupta@linux$(echo .)microsoft.com \
--cc=ssengar@linux$(echo .)microsoft.com \
--cc=tglx@linutronix$(echo .)de \
--cc=vkuznets@redhat$(echo .)com \
--cc=wei.liu@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox