From: Jakub Kicinski <kuba@kernel•org>
To: Shenwei Wang <shenwei.wang@nxp•com>
Cc: Marc Kleine-Budde <mkl@pengutronix•de>,
Russell King <linux@armlinux•org.uk>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Maxime Coquelin <mcoquelin.stm32@gmail•com>,
Shawn Guo <shawnguo@kernel•org>,
Sascha Hauer <s.hauer@pengutronix•de>,
Neil Armstrong <neil.armstrong@linaro•org>,
Kevin Hilman <khilman@baylibre•com>,
Vinod Koul <vkoul@kernel•org>, Chen-Yu Tsai <wens@csie•org>,
Jernej Skrabec <jernej.skrabec@gmail•com>,
Samuel Holland <samuel@sholland•org>,
Jose Abreu <joabreu@synopsys•com>,
"imx@lists•linux.dev" <imx@lists•linux.dev>,
Simon Horman <simon.horman@corigine•com>,
Alexandre Torgue <alexandre.torgue@foss•st.com>,
Giuseppe Cavallaro <peppe.cavallaro@st•com>,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba•co.jp>,
Fabio Estevam <festevam@gmail•com>,
"linux-stm32@st-md-mailman•stormreply.com"
<linux-stm32@st-md-mailman•stormreply.com>,
Jerome Brunet <jbrunet@baylibre•com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro•org>,
Wong Vee Khee <veekhee@apple•com>,
dl-linux-imx <linux-imx@nxp•com>,
Andrew Halaney <ahalaney@redhat•com>,
Bhupesh Sharma <bhupesh.sharma@linaro•org>,
Martin Blumenstingl <martin.blumenstingl@googlemail•com>,
Revanth Kumar Uppala <ruppala@nvidia•com>,
Jochen Henneberg <jh@henneberg-systemdesign•com>,
"linux-amlogic@lists•infradead.org"
<linux-amlogic@lists•infradead.org>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix•de>
Subject: Re: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter for fix_mac_speed
Date: Tue, 1 Aug 2023 12:58:28 -0700 [thread overview]
Message-ID: <20230801125828.209c5e88@kernel.org> (raw)
In-Reply-To: <AS8PR04MB9176FC45B9663B5BF964F58A890AA@AS8PR04MB9176.eurprd04.prod.outlook.com>
On Tue, 1 Aug 2023 18:43:52 +0000 Shenwei Wang wrote:
> Subject: RE: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter for fix_mac_speed
Looks like new platform enablement, the correct tree to target this
at is net-next (i.e. [PATCH net-next]).
> > -----Original Message-----
> > From: Marc Kleine-Budde <mkl@pengutronix•de>
> > Sent: Tuesday, August 1, 2023 1:37 AM
> > To: Shenwei Wang <shenwei.wang@nxp•com>
> > Cc: Russell King <linux@armlinux•org.uk>; David S. Miller
> > <davem@davemloft•net>; Eric Dumazet <edumazet@google•com>; Jakub
> > Kicinski <kuba@kernel•org>; Paolo Abeni <pabeni@redhat•com>; Maxime
> > Coquelin <mcoquelin.stm32@gmail•com>; Shawn Guo <shawnguo@kernel•org>;
> > Sascha Hauer <s.hauer@pengutronix•de>; Neil Armstrong
> > <neil.armstrong@linaro•org>; Kevin Hilman <khilman@baylibre•com>; Vinod
> > Koul <vkoul@kernel•org>; Chen-Yu Tsai <wens@csie•org>; Jernej Skrabec
> > <jernej.skrabec@gmail•com>; Samuel Holland <samuel@sholland•org>; Jose
> > Abreu <joabreu@synopsys•com>; imx@lists•linux.dev; Simon Horman
> > <simon.horman@corigine•com>; Alexandre Torgue
> > <alexandre.torgue@foss•st.com>; Giuseppe Cavallaro
> > <peppe.cavallaro@st•com>; Nobuhiro Iwamatsu
> > <nobuhiro1.iwamatsu@toshiba•co.jp>; Fabio Estevam <festevam@gmail•com>;
> > linux-stm32@st-md-mailman•stormreply.com; Jerome Brunet
> > <jbrunet@baylibre•com>; Bartosz Golaszewski
> > <bartosz.golaszewski@linaro•org>; Wong Vee Khee <veekhee@apple•com>; dl-
> > linux-imx <linux-imx@nxp•com>; Andrew Halaney <ahalaney@redhat•com>;
> > Bhupesh Sharma <bhupesh.sharma@linaro•org>; Martin Blumenstingl
> > <martin.blumenstingl@googlemail•com>; Revanth Kumar Uppala
> > <ruppala@nvidia•com>; Jochen Henneberg <jh@henneberg-systemdesign•com>;
> > linux-amlogic@lists•infradead.org; linux-arm-kernel@lists•infradead.org;
> > netdev@vger•kernel.org; linux-kernel@vger•kernel.org; Pengutronix Kernel
> > Team <kernel@pengutronix•de>
> > Subject: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter
> > for fix_mac_speed
Why is this quote included? Please get a sane email client.
> > On 31.07.2023 11:19:28, Shenwei Wang wrote:
> > > A mode parameter has been added to the callback function of
> > > fix_mac_speed to indicate the physical layer type.
> > >
> > > The mode can be one the following:
> > > MLO_AN_PHY - Conventional PHY
> > > MLO_AN_FIXED - Fixed-link mode
> > > MLO_AN_INBAND - In-band protocol
> > >
> > > Also use short version of 'uint' to replace the 'unsigned int' in the
> > > function definitions.
> >
> > There are not many users of 'uint' in the kernel and it's not used in the stmmac
> > driver so far. From my point of view I would not introduce it and stick to the
> > standard 'unsigned int'.
>
> Using 'uint' makes the code look cleaner because adding one extra
> parameter may cause some function declarations to span multiple
> lines. This change keeps function declarations compact on a single
> line.
Marc is right. Just do it.
next prev parent reply other threads:[~2023-08-01 19:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 16:19 [PATCH v3 net 0/2] update stmmac fix_mac_speed Shenwei Wang
2023-07-31 16:19 ` [PATCH v3 net 1/2] net: stmmac: add new mode parameter for fix_mac_speed Shenwei Wang
2023-08-01 6:37 ` Marc Kleine-Budde
2023-08-01 18:43 ` [EXT] " Shenwei Wang
2023-08-01 19:58 ` Jakub Kicinski [this message]
2023-08-02 19:33 ` Shenwei Wang
2023-08-01 10:52 ` kernel test robot
2023-07-31 16:19 ` [PATCH v3 net 2/2] net: stmmac: dwmac-imx: pause the TXC clock in fixed-link Shenwei Wang
2023-08-01 9:01 ` Marc Kleine-Budde
2023-08-01 12:47 ` Johannes Zink
2023-08-01 12:56 ` Russell King (Oracle)
2023-08-01 17:06 ` [EXT] " Shenwei Wang
2023-08-01 17:23 ` Andrew Halaney
2023-08-01 17:24 ` Russell King (Oracle)
2023-08-01 17:10 ` Shenwei Wang
2023-08-02 6:25 ` Johannes Zink
2023-08-02 14:27 ` Shenwei Wang
2023-08-02 14:40 ` Johannes Zink
2023-08-02 16:00 ` Shenwei Wang
2023-08-03 6:36 ` Johannes Zink
2023-08-03 13:08 ` Shenwei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801125828.209c5e88@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ahalaney@redhat$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=bartosz.golaszewski@linaro$(echo .)org \
--cc=bhupesh.sharma@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=imx@lists$(echo .)linux.dev \
--cc=jbrunet@baylibre$(echo .)com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=jh@henneberg-systemdesign$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=khilman@baylibre$(echo .)com \
--cc=linux-amlogic@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=martin.blumenstingl@googlemail$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=mkl@pengutronix$(echo .)de \
--cc=neil.armstrong@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba$(echo .)co.jp \
--cc=pabeni@redhat$(echo .)com \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=ruppala@nvidia$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=samuel@sholland$(echo .)org \
--cc=shawnguo@kernel$(echo .)org \
--cc=shenwei.wang@nxp$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=veekhee@apple$(echo .)com \
--cc=vkoul@kernel$(echo .)org \
--cc=wens@csie$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox