public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel•org>
To: Jinjian Song <songjinjian@hotmail•com>
Cc: netdev@vger•kernel.org, chandrashekar.devegowda@intel•com,
	chiranjeevi.rapolu@linux•intel.com, danielwinkler@google•com,
	davem@davemloft•net, edumazet@google•com,
	haijun.liu@mediatek•com, ilpo.jarvinen@linux•intel.com,
	jesse.brandeburg@intel•com, jinjian.song@fibocom•com,
	johannes@sipsolutions•net, kuba@kernel•org, linuxwwan@intel•com,
	linuxwwan_5g@intel•com, loic.poulain@linaro•org,
	m.chetan.kumar@linux•intel.com, pabeni@redhat•com,
	ricardo.martinez@linux•intel.com, ryazanov.s.a@gmail•com,
	soumya.prakash.mishra@intel•com, nmarupaka@google•com,
	vsankar@lenovo•com
Subject: Re: [net-next v2 5/5] net: wwan: t7xx: Devlink documentation
Date: Thu, 24 Aug 2023 17:47:05 +0200	[thread overview]
Message-ID: <20230824154705.GK3523530@kernel.org> (raw)
In-Reply-To: <MEYP282MB26978F449A3C639B1DB89984BB1CA@MEYP282MB2697.AUSP282.PROD.OUTLOOK.COM>

On Wed, Aug 23, 2023 at 10:21:29PM +0800, Jinjian Song wrote:
> From: Jinjian Song <jinjian.song@fibocom•com>
> 
> Document the t7xx devlink commands usage for firmware flashing &
> coredump collection.
> 
> Base on the v5 patch version of follow series:
> 'net: wwan: t7xx: fw flashing & coredump support'
> (https://patchwork.kernel.org/project/netdevbpf/patch/f902d4a0cb807a205687f7e693079fba72ca7341.1674307425.git.m.chetan.kumar@linux.intel.com/)
> 
> Signed-off-by: Jinjian Song <jinjian.song@fibocom•com>

Hi Jinjian Song,

some minor feedback from my side.

...

> +
> +Coredump Collection
> +~~~~~~~~~~~~~~~~~~

nit: the line above seems to need one more '~'

> +
> +::
> +
> +  $ devlink region new mr_dump
> +
> +::
> +
> +  $ devlink region read mr_dump snapshot 0 address 0 length $len
> +
> +::
> +
> +  $ devlink region del mr_dump snapshot 0
> +
> +Note: $len is actual len to be dumped.
> +
> +The userspace application uses these commands for obtaining the modem component
> +logs when device encounters an exception.
> +
> +Second Stage Bootloader dump
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~

Ditto.

> +
> +::
> +
> +  $ devlink region new lk_dump
> +
> +::
> +
> +  $ devlink region read lk_dump snapshot 0 address 0 length $len
> +
> +::
> +
> +  $ devlink region del lk_dump snapshot 0
> +
> +Note: $len is actual len to be dumped.
> +
> +In fastboot mode the userspace application uses these commands for obtaining the
> +current snapshot of second stage bootloader.
> +
> -- 
> 2.34.1
> 
> 

  reply	other threads:[~2023-08-24 15:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230823142129.20566-1-songjinjian@hotmail.com>
2023-08-23 14:21 ` [net-next v2 1/5] net: wwan: t7xx: Infrastructure for early port configuration Jinjian Song
2023-08-23 14:21 ` [net-next v2 2/5] net: wwan: t7xx: Register with devlink and implement firmware flashing Jinjian Song
2023-08-23 14:21 ` [net-next v2 3/5] net: wwan: t7xx: Creates region & snapshot for coredump log collection Jinjian Song
2023-08-23 14:21 ` [net-next v2 4/5] net: wwan: t7xx: Adds sysfs attribute of modem event Jinjian Song
2023-08-23 14:21 ` [net-next v2 5/5] net: wwan: t7xx: Devlink documentation Jinjian Song
2023-08-24 15:47   ` Simon Horman [this message]
2023-08-26 11:32   ` Jinjian Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230824154705.GK3523530@kernel.org \
    --to=horms@kernel$(echo .)org \
    --cc=chandrashekar.devegowda@intel$(echo .)com \
    --cc=chiranjeevi.rapolu@linux$(echo .)intel.com \
    --cc=danielwinkler@google$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=edumazet@google$(echo .)com \
    --cc=haijun.liu@mediatek$(echo .)com \
    --cc=ilpo.jarvinen@linux$(echo .)intel.com \
    --cc=jesse.brandeburg@intel$(echo .)com \
    --cc=jinjian.song@fibocom$(echo .)com \
    --cc=johannes@sipsolutions$(echo .)net \
    --cc=kuba@kernel$(echo .)org \
    --cc=linuxwwan@intel$(echo .)com \
    --cc=linuxwwan_5g@intel$(echo .)com \
    --cc=loic.poulain@linaro$(echo .)org \
    --cc=m.chetan.kumar@linux$(echo .)intel.com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=nmarupaka@google$(echo .)com \
    --cc=pabeni@redhat$(echo .)com \
    --cc=ricardo.martinez@linux$(echo .)intel.com \
    --cc=ryazanov.s.a@gmail$(echo .)com \
    --cc=songjinjian@hotmail$(echo .)com \
    --cc=soumya.prakash.mishra@intel$(echo .)com \
    --cc=vsankar@lenovo$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox