From: Stephen Hemminger <stephen@networkplumber•org>
To: Kees Cook <keescook@chromium•org>
Cc: Jamal Hadi Salim <jhs@mojatatu•com>,
Cong Wang <xiyou.wangcong@gmail•com>,
Jiri Pirko <jiri@resnulli•us>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
netdev@vger•kernel.org,
"Gustavo A. R. Silva" <gustavoars@kernel•org>,
Nathan Chancellor <nathan@kernel•org>,
Nick Desaulniers <ndesaulniers@google•com>,
Tom Rix <trix@redhat•com>,
linux-kernel@vger•kernel.org, linux-hardening@vger•kernel.org,
llvm@lists•linux.dev
Subject: Re: [PATCH] netem: Annotate struct disttable with __counted_by
Date: Tue, 3 Oct 2023 20:32:40 -0700 [thread overview]
Message-ID: <20231003203240.45705fde@hermes.local> (raw)
In-Reply-To: <20231003231823.work.684-kees@kernel.org>
On Tue, 3 Oct 2023 16:18:23 -0700
Kees Cook <keescook@chromium•org> wrote:
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
> array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct disttable.
>
> Cc: Stephen Hemminger <stephen@networkplumber•org>
> Cc: Jamal Hadi Salim <jhs@mojatatu•com>
> Cc: Cong Wang <xiyou.wangcong@gmail•com>
> Cc: Jiri Pirko <jiri@resnulli•us>
> Cc: "David S. Miller" <davem@davemloft•net>
> Cc: Eric Dumazet <edumazet@google•com>
> Cc: Jakub Kicinski <kuba@kernel•org>
> Cc: Paolo Abeni <pabeni@redhat•com>
> Cc: netdev@vger•kernel.org
> Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci [1]
> Signed-off-by: Kees Cook <keescook@chromium•org
Reviewed-by: Stephen Hemminger <stephen@networkplumber•org>
PS: size is intended wrong in original code but that is not important.
Should have lined up with table[].
next prev parent reply other threads:[~2023-10-04 3:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 23:18 [PATCH] netem: Annotate struct disttable with __counted_by Kees Cook
2023-10-03 23:38 ` Gustavo A. R. Silva
2023-10-04 3:32 ` Stephen Hemminger [this message]
2023-10-06 1:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003203240.45705fde@hermes.local \
--to=stephen@networkplumber$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gustavoars@kernel$(echo .)org \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=keescook@chromium$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-hardening@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=llvm@lists$(echo .)linux.dev \
--cc=nathan@kernel$(echo .)org \
--cc=ndesaulniers@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=trix@redhat$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox