From: Rohan G Thomas <rohan.g.thomas@intel•com>
To: kuba@kernel•org
Cc: alexandre.torgue@foss•st.com, andriy.shevchenko@linux•intel.com,
davem@davemloft•net, devicetree@vger•kernel.org,
edumazet@google•com, fancer.lancer@gmail•com,
joabreu@synopsys•com, linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
mcoquelin.stm32@gmail•com, netdev@vger•kernel.org,
pabeni@redhat•com, rohan.g.thomas@intel•com
Subject: Re: [PATCH net-next 1/1] net: stmmac: xgmac: EST interrupts handling
Date: Fri, 6 Oct 2023 15:23:19 +0800 [thread overview]
Message-ID: <20231006072319.22441-1-rohan.g.thomas@intel.com> (raw)
In-Reply-To: <20231005070538.0826bf9d@kernel.org>
On Thu, 5 Oct 2023 07:05:38 -0700 Jakub Kicinski wrote:
> On Thu, 5 Oct 2023 20:14:41 +0800 Rohan G Thomas wrote:
> > > So the question now is whether we want Rohan to do this conversion
> > > _first_, in DW QoS 5, and then add xgmac part. Or the patch should
> > > go in as is and you'll follow up with the conversion?
> >
> > If agreed, this commit can go in. I can submit another patch with the
> > refactoring suggested by Serge.
>
> Did you miss the emphasis I put on the word "first" in my reply?
> Cleanup first, nobody will be keeping track whether your fulfilled your
> promises or not :|
Hi Jakub,
Agreed. I'll do the cleanup first.
Best Regards,
Rohan
next prev parent reply other threads:[~2023-10-06 7:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 3:10 [PATCH net-next 1/1] net: stmmac: xgmac: EST interrupts handling Rohan G Thomas
2023-09-26 11:25 ` Serge Semin
2023-10-02 20:55 ` Jakub Kicinski
2023-10-03 11:12 ` Serge Semin
2023-10-04 16:26 ` Jakub Kicinski
2023-10-05 12:14 ` Rohan G Thomas
2023-10-05 14:05 ` Jakub Kicinski
2023-10-06 7:23 ` Rohan G Thomas [this message]
2023-10-06 10:08 ` Serge Semin
2023-10-06 13:35 ` Jakub Kicinski
2023-12-01 6:49 ` Rohan G Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231006072319.22441-1-rohan.g.thomas@intel.com \
--to=rohan.g.thomas@intel$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=fancer.lancer@gmail$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox