From: Rohan G Thomas <rohan.g.thomas@intel•com>
To: fancer.lancer@gmail•com
Cc: alexandre.torgue@foss•st.com, andriy.shevchenko@linux•intel.com,
davem@davemloft•net, edumazet@google•com, joabreu@synopsys•com,
kuba@kernel•org, linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
mcoquelin.stm32@gmail•com, netdev@vger•kernel.org,
pabeni@redhat•com, rohan.g.thomas@intel•com
Subject: Re: [PATCH net-next 1/1] net: stmmac: xgmac: EST interrupts handling
Date: Fri, 1 Dec 2023 14:49:09 +0800 [thread overview]
Message-ID: <20231201064909.28399-1-rohan.g.thomas@intel.com> (raw)
In-Reply-To: <cjgx6e3agc6gpvs75nhkf6wlztk73epmct6tcuooyqvk2nx2o2@vr5buyk637t3>
On Fri, 6 Oct 2023 13:08:33 +0300 Serge Semin wrote:
> Hi Rohan, Jakub
> ...
> Interesting thing. My DW QoS Eth _v5.10a_ HW manual explicitly states that
> it's multiplied by _6_ in nanoseconds (just rechecked). So either there is a
> difference between the minor DW QoS Eth IP-core releases or the older HW-
> manuals have had a typo in the MTL_EST_CONTROL.PTOV field description.
> Synopsys normally describes such changes (whether it was a mistake or a
> functional change) in the IP-core release notes. The release notes document
> is supplied as a separate pdf file. Alas I don't have one.( Even if I had it it
> would have been useless since the change was introduced in the newer QoS
> IP-cores. Rohan, do you happen to have the release notes for DW QoS Eth IP-
> core v5.30 at hands?
> Something like DWC_ether_qos_rc_relnotes.pdf?
Hi Serge,
Sorry for the delay. Sends out another version with the suggested changes.
Managed to get DWC_ether_qos_relnotes.pdf for v5.20a and v5.30a. But I couldn't
find anything related to this. So for refactoring, I'm keeping the logic as in
the upstream code to avoid any regression.
>
> Also please double check that your DW QoS Eth v5.30a for sure states that
> MTL_EST_CONTROL.PTOV contains value multiplied by _6_. So we wouldn't
> be wasting time trying to workaround a more complex problem than we
> already have.
Yes, I checked this again. For DW QoS Eth v5.30a the multiplier for
MTL_EST_CONTROL.PTOV is _9_ as per the databook.
Also noticed a similar difference for MTL_EST_Status.BTRL field length. As per
the upstream code and DW QoS Eth v5.10a databook this field covers bit 8 to bit
11. But for the xgmac IP and DW QoS Eth v5.30a databook this field covers bit 8
to bit 15. Again nothing mentioned in the release notes. Here also I'm keeping
the logic as in the upstream code to avoid any regression.
>
> -Serge(y)
>
Best Regards,
Rohan
prev parent reply other threads:[~2023-12-01 6:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 3:10 [PATCH net-next 1/1] net: stmmac: xgmac: EST interrupts handling Rohan G Thomas
2023-09-26 11:25 ` Serge Semin
2023-10-02 20:55 ` Jakub Kicinski
2023-10-03 11:12 ` Serge Semin
2023-10-04 16:26 ` Jakub Kicinski
2023-10-05 12:14 ` Rohan G Thomas
2023-10-05 14:05 ` Jakub Kicinski
2023-10-06 7:23 ` Rohan G Thomas
2023-10-06 10:08 ` Serge Semin
2023-10-06 13:35 ` Jakub Kicinski
2023-12-01 6:49 ` Rohan G Thomas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231201064909.28399-1-rohan.g.thomas@intel.com \
--to=rohan.g.thomas@intel$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=fancer.lancer@gmail$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox