From: Jakub Kicinski <kuba@kernel•org>
To: Pedro Tammela <pctammela@mojatatu•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net, edumazet@google•com,
pabeni@redhat•com, jhs@mojatatu•com, xiyou.wangcong@gmail•com,
jiri@resnulli•us, marcelo.leitner@gmail•com, vladbu@nvidia•com,
Victor Nogueira <victor@mojatatu•com>
Subject: Re: [PATCH net-next 2/4] net/sched: add helper to check if a notification is needed
Date: Sat, 2 Dec 2023 11:18:12 -0800 [thread overview]
Message-ID: <20231202111812.0efcdd77@kernel.org> (raw)
In-Reply-To: <20231201204314.220543-3-pctammela@mojatatu.com>
On Fri, 1 Dec 2023 17:43:12 -0300 Pedro Tammela wrote:
> +static inline bool tc_should_notify(const struct net *net, u16 nlflags)
nit: tc_notify_needed() ? doesn't matter
> +{
> + return (nlflags & NLM_F_ECHO) || rtnl_has_listeners(net, RTNLGRP_TC);
I think it'd be nice to have an rtnl_* helper which looks at the flags
as well. With a proper kdoc. Maybe someone will notice that and remember
to implement F_ECHO for their command?
next prev parent reply other threads:[~2023-12-02 19:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 20:43 [PATCH net-next 0/4] net/sched: conditional notification of events for cls and act Pedro Tammela
2023-12-01 20:43 ` [PATCH net-next 1/4] rtnl: add helper to check if rtnl group has listeners Pedro Tammela
2023-12-01 20:43 ` [PATCH net-next 2/4] net/sched: add helper to check if a notification is needed Pedro Tammela
2023-12-02 19:18 ` Jakub Kicinski [this message]
2023-12-04 14:50 ` Pedro Tammela
2023-12-01 20:43 ` [PATCH net-next 3/4] net/sched: act_api: conditional notification of events Pedro Tammela
2023-12-02 19:21 ` Jakub Kicinski
2023-12-04 14:52 ` Pedro Tammela
2023-12-01 20:43 ` [PATCH net-next 4/4] net/sched: cls_api: " Pedro Tammela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231202111812.0efcdd77@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=marcelo.leitner@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pctammela@mojatatu$(echo .)com \
--cc=victor@mojatatu$(echo .)com \
--cc=vladbu@nvidia$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox