From: Simon Horman <horms@kernel•org>
To: Zhipeng Lu <alexious@zju•edu.cn>
Cc: Chuck Lever <chuck.lever@oracle•com>,
Jeff Layton <jlayton@kernel•org>, Neil Brown <neilb@suse•de>,
Olga Kornievskaia <kolga@netapp•com>,
Dai Ngo <Dai.Ngo@oracle•com>, Tom Talpey <tom@talpey•com>,
Trond Myklebust <trond.myklebust@hammerspace•com>,
Anna Schumaker <anna@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Simo Sorce <simo@redhat•com>, Steve Dickson <steved@redhat•com>,
Kevin Coffman <kwc@citi•umich.edu>,
linux-nfs@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH] [v2] SUNRPC: fix a memleak in gss_import_v2_context
Date: Mon, 15 Jan 2024 11:09:05 +0000 [thread overview]
Message-ID: <20240115110905.GR392144@kernel.org> (raw)
In-Reply-To: <20240112084540.3729001-1-alexious@zju.edu.cn>
On Fri, Jan 12, 2024 at 04:45:38PM +0800, Zhipeng Lu wrote:
> The ctx->mech_used.data allocated by kmemdup is not freed in neither
> gss_import_v2_context nor it only caller radeon_driver_open_kms.
Should radeon_driver_open_kms be gss_krb5_import_sec_context?
Also, perhaps it is useful to write something like this:
... gss_krb5_import_sec_context, which frees ctx on error.
> Thus, this patch reform the last call of gss_import_v2_context to the
> gss_krb5_import_ctx_v2, preventing the memleak while keepping the return
> formation.
>
> Fixes: 47d848077629 ("gss_krb5: handle new context format from gssd")
> Signed-off-by: Zhipeng Lu <alexious@zju•edu.cn>
Hi Zhipeng Lu,
Other than the comment above, I agree with your analysis.
And that although the problem has changed form slightly,
it was originally introduced by the cited commit.
I also agree that your fix.
...
next prev parent reply other threads:[~2024-01-15 11:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 8:45 [PATCH] [v2] SUNRPC: fix a memleak in gss_import_v2_context Zhipeng Lu
2024-01-12 13:23 ` Jeff Layton
2024-01-12 19:24 ` Jakub Kicinski
2024-01-12 19:27 ` Chuck Lever III
2024-01-12 20:01 ` Jakub Kicinski
2024-01-15 11:09 ` Simon Horman [this message]
2024-01-15 14:23 ` Chuck Lever III
2024-01-17 7:44 ` alexious
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240115110905.GR392144@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=Dai.Ngo@oracle$(echo .)com \
--cc=alexious@zju$(echo .)edu.cn \
--cc=anna@kernel$(echo .)org \
--cc=chuck.lever@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jlayton@kernel$(echo .)org \
--cc=kolga@netapp$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kwc@citi$(echo .)umich.edu \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=neilb@suse$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=simo@redhat$(echo .)com \
--cc=steved@redhat$(echo .)com \
--cc=tom@talpey$(echo .)com \
--cc=trond.myklebust@hammerspace$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox