From: Simon Horman <horms@kernel•org>
To: Jakub Kicinski <kuba@kernel•org>
Cc: davem@davemloft•net, netdev@vger•kernel.org, edumazet@google•com,
pabeni@redhat•com, shuah@kernel•org,
linux-kselftest@vger•kernel.org
Subject: Re: [PATCH net v2] selftests: net: fix rps_default_mask with >32 CPUs
Date: Sun, 21 Jan 2024 20:34:33 +0000 [thread overview]
Message-ID: <20240121203433.GA119808@kernel.org> (raw)
In-Reply-To: <20240120210256.3864747-1-kuba@kernel.org>
On Sat, Jan 20, 2024 at 01:02:56PM -0800, Jakub Kicinski wrote:
> If there is more than 32 cpus the bitmask will start to contain
> commas, leading to:
>
> ./rps_default_mask.sh: line 36: [: 00000000,00000000: integer expression expected
>
> Remove the commas, bash doesn't interpret leading zeroes as oct
> so that should be good enough.
>
> Fixes: c12e0d5f267d ("self-tests: introduce self-tests for RPS default mask")
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>
> ---
> v2:
> - remove all commas
> v1: https://lore.kernel.org/all/20240119151248.3476897-1-kuba@kernel.org/
Thanks,
this version looks good to me.
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2024-01-21 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-20 21:02 [PATCH net v2] selftests: net: fix rps_default_mask with >32 CPUs Jakub Kicinski
2024-01-21 20:34 ` Simon Horman [this message]
2024-01-21 20:37 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240121203433.GA119808@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=shuah@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox