From: Stephen Hemminger <stephen@networkplumber•org>
To: Maks Mishin <maks.mishinfz@gmail•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] m_ife: Remove unused value
Date: Wed, 17 Apr 2024 15:30:07 -0700 [thread overview]
Message-ID: <20240417153007.4bca29aa@hermes.local> (raw)
In-Reply-To: <CAEh9MGTwqGVpuq8M+So8bfU2y=bpbQMJjPJo3F52MjFHQ_BiRQ@mail.gmail.com>
On Wed, 17 Apr 2024 20:08:55 +0300
Maks Mishin <maks.mishinfz@gmail•com> wrote:
> > ife_type = rta_getattr_u16(tb[TCA_IFE_TYPE]);
> > - has_optional = 1;
> > print_0xhex(PRINT_ANY, "type", "type %#llX ", ife_type);
> > }
> >
> > - if (has_optional)
> > - print_string(PRINT_FP, NULL, "%s\t", _SL_);
> > -
It is used. The printout would change with your patch. It would cause more
things to be one line.
The lower two has_optional parts have no effect and could be removed.
But before removing them, it would to look back in older versions
of iproute2 before JSON was introduced to see if this was something
that got mangled then.
next prev parent reply other threads:[~2024-04-17 22:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 17:07 [PATCH] m_ife: Remove unused value Maks Mishin
[not found] ` <CAEh9MGTwqGVpuq8M+So8bfU2y=bpbQMJjPJo3F52MjFHQ_BiRQ@mail.gmail.com>
2024-04-17 22:30 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-18 19:44 Maks Mishin
2024-02-19 17:59 ` Stephen Hemminger
2024-02-20 14:32 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417153007.4bca29aa@hermes.local \
--to=stephen@networkplumber$(echo .)org \
--cc=maks.mishinfz@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox