From: Simon Horman <horms@kernel•org>
To: Hangbin Liu <liuhangbin@gmail•com>
Cc: netdev@vger•kernel.org, Jay Vosburgh <j.vosburgh@gmail•com>,
"David S . Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Eric Dumazet <edumazet@google•com>,
Nikolay Aleksandrov <razor@blackwall•org>,
Tariq Toukan <tariqt@nvidia•com>, Jianbo Liu <jianbol@nvidia•com>,
Sabrina Dubroca <sd@queasysnail•net>
Subject: Re: [PATCHv2 net-next 1/3] bonding: add common function to check ipsec device
Date: Mon, 19 Aug 2024 15:37:53 +0100 [thread overview]
Message-ID: <20240819143753.GF11472@kernel.org> (raw)
In-Reply-To: <20240819075334.236334-2-liuhangbin@gmail.com>
On Mon, Aug 19, 2024 at 03:53:31PM +0800, Hangbin Liu wrote:
> This patch adds a common function to check the status of IPSec devices.
> This function will be useful for future implementations, such as IPSec ESN
> and state offload callbacks.
>
> Suggested-by: Nikolay Aleksandrov <razor@blackwall•org>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail•com>
> ---
> drivers/net/bonding/bond_main.c | 43 +++++++++++++++++++++++----------
> 1 file changed, 30 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index f9633a6f8571..250a2717b4e9 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -418,6 +418,34 @@ static int bond_vlan_rx_kill_vid(struct net_device *bond_dev,
> /*---------------------------------- XFRM -----------------------------------*/
>
> #ifdef CONFIG_XFRM_OFFLOAD
> +/**
> + * bond_ipsec_dev - return the device for ipsec offload, or NULL if not exist
> + * caller must hold rcu_read_lock.
> + * @xs: pointer to transformer state struct
> + **/
> +static struct net_device bond_ipsec_dev(struct xfrm_state *xs)
Hi Hangbin,
Based on the implementation of the function, it looks like it should return
'struct net_device *' rather than 'struct net_device' (a '*' is missing).
> +{
> + struct net_device *bond_dev = xs->xso.dev;
> + struct net_device *real_dev;
> + struct bonding *bond;
> + struct slave *slave;
> +
> + if (!bond_dev)
> + return NULL;
> +
> + bond = netdev_priv(bond_dev);
> + slave = rcu_dereference(bond->curr_active_slave);
> + real_dev = slave ? slave->dev : NULL;
> +
> + if ((BOND_MODE(bond) != BOND_MODE_ACTIVEBACKUP) ||
> + !slave || !real_dev || !xs->xso.real_dev)
> + return NULL;
> +
> + WARN_ON(xs->xso.real_dev != slave->dev);
> +
> + return real_dev;
> +}
> +
> /**
> * bond_ipsec_add_sa - program device with a security association
> * @xs: pointer to transformer state struct
--
pw-bot: cr
next prev parent reply other threads:[~2024-08-19 14:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 7:53 [PATCHv2 net-next 0/2] Bonding: support new xfrm state offload functions Hangbin Liu
2024-08-19 7:53 ` [PATCHv2 net-next 1/3] bonding: add common function to check ipsec device Hangbin Liu
2024-08-19 8:02 ` Nikolay Aleksandrov
2024-08-19 8:43 ` Hangbin Liu
2024-08-19 8:48 ` Nikolay Aleksandrov
2024-08-19 14:37 ` Simon Horman [this message]
2024-08-19 23:07 ` Hangbin Liu
2024-08-19 19:24 ` kernel test robot
2024-08-19 20:16 ` kernel test robot
2024-08-19 7:53 ` [PATCHv2 net-next 2/3] bonding: Add ESN support to IPSec HW offload Hangbin Liu
2024-08-19 8:03 ` Nikolay Aleksandrov
2024-08-19 21:17 ` kernel test robot
2024-08-19 23:01 ` Hangbin Liu
2024-08-19 7:53 ` [PATCHv2 net-next 3/3] bonding: support xfrm state update Hangbin Liu
2024-08-19 8:03 ` Nikolay Aleksandrov
2024-08-19 8:43 ` [PATCHv2 net-next 0/2] Bonding: support new xfrm state offload functions Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240819143753.GF11472@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=j.vosburgh@gmail$(echo .)com \
--cc=jianbol@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=liuhangbin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=sd@queasysnail$(echo .)net \
--cc=tariqt@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox