From: Simon Horman <horms@kernel•org>
To: 2694439648@qq•com
Cc: alexandre.torgue@foss•st.com, joabreu@synopsys•com,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, mcoquelin.stm32@gmail•com,
netdev@vger•kernel.org, linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, hailong.fan@siengine•com
Subject: Re: [PATCH] net: stmmac: enable MAC after MTL configuring
Date: Thu, 17 Oct 2024 11:18:57 +0100 [thread overview]
Message-ID: <20241017101857.GE1697@kernel.org> (raw)
In-Reply-To: <tencent_6BF819F333D995B4D3932826194B9B671207@qq.com>
On Mon, Oct 14, 2024 at 01:44:03PM +0800, 2694439648@qq•com wrote:
> From: "hailong.fan" <hailong.fan@siengine•com>
>
> DMA maybe block while ETH is opening,
> Adjust the enable sequence, put the MAC enable last
>
> Signed-off-by: hailong.fan <hailong.fan@siengine•com>
Hi,
I think that some more explanation of this is required.
Including if a problem has been observed, and if so under what
conditions. Or, if not, some background information on why
this adjustment is correct.
I also think some explanation is required of the relationship
between the changes this patch makes to setup, and the
changes it makes to start and stop.
...
next prev parent reply other threads:[~2024-10-17 10:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 5:44 [PATCH] net: stmmac: enable MAC after MTL configuring 2694439648
2024-10-17 10:18 ` Simon Horman [this message]
2024-10-18 1:15 ` 回复: " Fan Hailong/范海龙
2024-10-18 17:57 ` Andrew Lunn
2024-10-20 1:45 ` 回复: " Fan Hailong/范海龙
2024-10-20 14:49 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017101857.GE1697@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=2694439648@qq$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hailong.fan@siengine$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox