From: Jakub Kicinski <kuba@kernel•org>
To: Rahul Rameshbabu <rrameshbabu@nvidia•com>
Cc: "Arinzon, David" <darinzon@amazon•com>,
Gal Pressman <gal@nvidia•com>, David Miller <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Richard Cochran <richardcochran@gmail•com>,
"Woodhouse, David" <dwmw@amazon•co.uk>,
"Machulsky, Zorik" <zorik@amazon•com>,
"Matushevsky, Alexander" <matua@amazon•com>,
"Bshara, Saeed" <saeedb@amazon•com>,
"Wilson, Matt" <msw@amazon•com>,
"Liguori, Anthony" <aliguori@amazon•com>,
"Bshara, Nafea" <nafea@amazon•com>,
"Schmeilin, Evgeny" <evgenys@amazon•com>,
"Belgazal, Netanel" <netanel@amazon•com>,
"Saidi, Ali" <alisaidi@amazon•com>,
"Herrenschmidt, Benjamin" <benh@amazon•com>,
"Kiyanovski, Arthur" <akiyano@amazon•com>,
"Dagan, Noam" <ndagan@amazon•com>,
"Bernstein, Amit" <amitbern@amazon•com>,
"Agroskin, Shay" <shayagr@amazon•com>,
"Abboud, Osama" <osamaabb@amazon•com>,
"Ostrovsky, Evgeny" <evostrov@amazon•com>,
"Tabachnik, Ofir" <ofirt@amazon•com>,
"Machnikowski, Maciek" <maciek@machnikowski•net>
Subject: Re: [PATCH v3 net-next 3/3] net: ena: Add PHC documentation
Date: Tue, 5 Nov 2024 18:15:52 -0800 [thread overview]
Message-ID: <20241105181552.02ea5525@kernel.org> (raw)
In-Reply-To: <875xp1azla.fsf@nvidia.com>
On Tue, 05 Nov 2024 18:02:57 -0800 Rahul Rameshbabu wrote:
> I do think the phc-to-host related statistics are on the niche side of
> things. The following drivers are error free in their gettimex64 paths.
>
> * AMD pesando/ionic
> * Broadcom Tigon3
> * Intel ixgbe
> * Intel igc
> * NVIDIA mlxsw
> * NVIDIA mlx5_core
>
> The above drivers would definitely not benefit from having "phc
> (nic)"-to-host related statistics being presented here. I am more in
> favor of making these statistics specific to amazon's ENA driver since I
> think most drivers do not have a complex . Also, what value is there in
> the count of phc-to-host successful/failed operations versus just
> keeping track of the errors in userspace for whoever is calling
> clock_gettime. I am somewhat ok with these counters, but I honestly
> cannot imagine any practical use to this especially since they are not
> related to anything over-the-wire. So the errors in userspace would be
> enough of an indicator of whether there is excessive utilization of the
> requests and the counters seem redundant to that (at least to me). Feel
> free to share how you feel these counters would be helpful beyond
> handling the return codes through clock_gettime. I might just be missing
> something.
Agreed, thanks a lot for the analysis. I misread the code.
I looked at ena_com_phc_get() last night and incorrectly
assumed it's way to complex to be called from gettimex64 :S
next prev parent reply other threads:[~2024-11-06 2:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-03 11:31 [PATCH v3 net-next 0/3] PHC support in ENA driver David Arinzon
2024-11-03 11:31 ` [PATCH v3 net-next 1/3] net: ena: Add PHC support in the " David Arinzon
2024-11-03 11:31 ` [PATCH v3 net-next 2/3] net: ena: PHC silent reset David Arinzon
2024-11-03 11:31 ` [PATCH v3 net-next 3/3] net: ena: Add PHC documentation David Arinzon
2024-11-05 2:17 ` Jakub Kicinski
2024-11-05 10:52 ` Arinzon, David
2024-11-05 16:16 ` Gal Pressman
2024-11-05 16:52 ` Arinzon, David
2024-11-06 2:02 ` Rahul Rameshbabu
2024-11-06 2:15 ` Jakub Kicinski [this message]
2024-11-06 1:28 ` Jakub Kicinski
2024-11-12 17:53 ` Arinzon, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105181552.02ea5525@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=akiyano@amazon$(echo .)com \
--cc=aliguori@amazon$(echo .)com \
--cc=alisaidi@amazon$(echo .)com \
--cc=amitbern@amazon$(echo .)com \
--cc=benh@amazon$(echo .)com \
--cc=darinzon@amazon$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dwmw@amazon$(echo .)co.uk \
--cc=edumazet@google$(echo .)com \
--cc=evgenys@amazon$(echo .)com \
--cc=evostrov@amazon$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=maciek@machnikowski$(echo .)net \
--cc=matua@amazon$(echo .)com \
--cc=msw@amazon$(echo .)com \
--cc=nafea@amazon$(echo .)com \
--cc=ndagan@amazon$(echo .)com \
--cc=netanel@amazon$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ofirt@amazon$(echo .)com \
--cc=osamaabb@amazon$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=rrameshbabu@nvidia$(echo .)com \
--cc=saeedb@amazon$(echo .)com \
--cc=shayagr@amazon$(echo .)com \
--cc=zorik@amazon$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox