From: "Arinzon, David" <darinzon@amazon•com>
To: Gal Pressman <gal@nvidia•com>, Jakub Kicinski <kuba@kernel•org>
Cc: David Miller <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Richard Cochran <richardcochran@gmail•com>,
"Woodhouse, David" <dwmw@amazon•co.uk>,
"Machulsky, Zorik" <zorik@amazon•com>,
"Matushevsky, Alexander" <matua@amazon•com>,
"Bshara, Saeed" <saeedb@amazon•com>,
"Wilson, Matt" <msw@amazon•com>,
"Liguori, Anthony" <aliguori@amazon•com>,
"Bshara, Nafea" <nafea@amazon•com>,
"Schmeilin, Evgeny" <evgenys@amazon•com>,
"Belgazal, Netanel" <netanel@amazon•com>,
"Saidi, Ali" <alisaidi@amazon•com>,
"Herrenschmidt, Benjamin" <benh@amazon•com>,
"Kiyanovski, Arthur" <akiyano@amazon•com>,
"Dagan, Noam" <ndagan@amazon•com>,
"Bernstein, Amit" <amitbern@amazon•com>,
"Agroskin, Shay" <shayagr@amazon•com>,
"Abboud, Osama" <osamaabb@amazon•com>,
"Ostrovsky, Evgeny" <evostrov@amazon•com>,
"Tabachnik, Ofir" <ofirt@amazon•com>,
"Machnikowski, Maciek" <maciek@machnikowski•net>,
"Rahul Rameshbabu" <rrameshbabu@nvidia•com>
Subject: RE: [PATCH v3 net-next 3/3] net: ena: Add PHC documentation
Date: Tue, 5 Nov 2024 16:52:11 +0000 [thread overview]
Message-ID: <4ba02d13a8c14045b0df7deaee188f82@amazon.com> (raw)
In-Reply-To: <91932534-7309-4650-b4c8-1bfe61579b50@nvidia.com>
> >>> +=================
> >> ======================================================
> >>> +**phc_cnt** Number of successful retrieved timestamps (below
> >> expire timeout).
> >>> +**phc_exp** Number of expired retrieved timestamps (above
> >> expire timeout).
> >>> +**phc_skp** Number of skipped get time attempts (during block
> >> period).
> >>> +**phc_err** Number of failed get time attempts (entering into
> block
> >> state).
> >>> +=================
> >> ======================================================
> >>
> >> I seem to recall we had an unpleasant conversation about using
> >> standard stats recently. Please tell me where you looked to check if
> >> Linux has standard stats for packet timestamping. We need to add the
> right info there.
> >> --
> >> pw-bot: cr
> >
> > Hi Jakub,
> >
> > Just wanted to clarify that this feature and the associated
> > documentation are specifically intended for reading a HW timestamp, not
> for TX/RX packet timestamping.
> > We reviewed similar drivers that support HW timestamping via
> > `gettime64` and `gettimex64` APIs, and we couldn't identify any that
> capture or report statistics related to reading a HW timestamp.
> > Let us know if further details would be helpful.
>
> David, did you consider Rahul's recent timestamping stats API?
> 0e9c127729be ("ethtool: add interface to read Tx hardware timestamping
> statistics")
Hi Gal,
We've looked into the `get_ts_stats` ethtool hook, and it refers to TX HW packet timestamping
and not HW timestamp which is retrieved through `gettime64` and `gettimex64`.
next prev parent reply other threads:[~2024-11-05 16:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-03 11:31 [PATCH v3 net-next 0/3] PHC support in ENA driver David Arinzon
2024-11-03 11:31 ` [PATCH v3 net-next 1/3] net: ena: Add PHC support in the " David Arinzon
2024-11-03 11:31 ` [PATCH v3 net-next 2/3] net: ena: PHC silent reset David Arinzon
2024-11-03 11:31 ` [PATCH v3 net-next 3/3] net: ena: Add PHC documentation David Arinzon
2024-11-05 2:17 ` Jakub Kicinski
2024-11-05 10:52 ` Arinzon, David
2024-11-05 16:16 ` Gal Pressman
2024-11-05 16:52 ` Arinzon, David [this message]
2024-11-06 2:02 ` Rahul Rameshbabu
2024-11-06 2:15 ` Jakub Kicinski
2024-11-06 1:28 ` Jakub Kicinski
2024-11-12 17:53 ` Arinzon, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ba02d13a8c14045b0df7deaee188f82@amazon.com \
--to=darinzon@amazon$(echo .)com \
--cc=akiyano@amazon$(echo .)com \
--cc=aliguori@amazon$(echo .)com \
--cc=alisaidi@amazon$(echo .)com \
--cc=amitbern@amazon$(echo .)com \
--cc=benh@amazon$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dwmw@amazon$(echo .)co.uk \
--cc=edumazet@google$(echo .)com \
--cc=evgenys@amazon$(echo .)com \
--cc=evostrov@amazon$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=maciek@machnikowski$(echo .)net \
--cc=matua@amazon$(echo .)com \
--cc=msw@amazon$(echo .)com \
--cc=nafea@amazon$(echo .)com \
--cc=ndagan@amazon$(echo .)com \
--cc=netanel@amazon$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ofirt@amazon$(echo .)com \
--cc=osamaabb@amazon$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=rrameshbabu@nvidia$(echo .)com \
--cc=saeedb@amazon$(echo .)com \
--cc=shayagr@amazon$(echo .)com \
--cc=zorik@amazon$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox