From: Jakub Kicinski <kuba@kernel•org>
To: Bhargava Marreddy <bhargava.marreddy@broadcom•com>
Cc: davem@davemloft•net, edumazet@google•com, pabeni@redhat•com,
andrew+netdev@lunn•ch, horms@kernel•org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, michael.chan@broadcom•com,
pavan.chebbi@broadcom•com, vsrama-krishna.nemani@broadcom•com,
vikas.gupta@broadcom•com,
Rajashekar Hudumula <rajashekar.hudumula@broadcom•com>,
Ajit Kumar Khaparde <ajit.khaparde@broadcom•com>
Subject: Re: [PATCH net-next 2/7] bng_en: query PHY capabilities and report link status
Date: Tue, 24 Feb 2026 18:35:28 -0800 [thread overview]
Message-ID: <20260224183528.757e1174@kernel.org> (raw)
In-Reply-To: <20260223163641.755200-3-bhargava.marreddy@broadcom.com>
On Mon, 23 Feb 2026 22:06:36 +0530 Bhargava Marreddy wrote:
> + /* To protect link related settings during link changes and
> + * ethtool settings changes.
> + */
> + struct mutex link_lock;
> + struct bnge_link_info link_info;
Why does link deserve its own lock? Are the operations slow?
bnxt was written before the netdev instance lock existed, if you're
just trying to avoid taking rtnl_lock the instance lock would do.
next prev parent reply other threads:[~2026-02-25 2:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 16:36 [PATCH net-next 0/7] bng_en: add link management and statistics support Bhargava Marreddy
2026-02-23 16:36 ` [PATCH net-next 1/7] bng_en: add per-PF workqueue, timer, and slow-path task Bhargava Marreddy
2026-02-25 2:32 ` Jakub Kicinski
2026-02-26 14:05 ` Bhargava Chenna Marreddy
2026-02-23 16:36 ` [PATCH net-next 2/7] bng_en: query PHY capabilities and report link status Bhargava Marreddy
2026-02-25 2:35 ` Jakub Kicinski [this message]
2026-02-26 14:24 ` Bhargava Chenna Marreddy
2026-02-23 16:36 ` [PATCH net-next 3/7] bng_en: add ethtool link settings, get_link, and nway_reset Bhargava Marreddy
2026-02-23 19:44 ` Andrew Lunn
2026-02-24 19:19 ` Bhargava Chenna Marreddy
2026-02-24 0:12 ` [net-next,3/7] " Jakub Kicinski
2026-02-25 18:11 ` Bhargava Chenna Marreddy
2026-02-23 16:36 ` [PATCH net-next 4/7] bng_en: add support for link async events Bhargava Marreddy
2026-02-23 16:36 ` [PATCH net-next 5/7] bng_en: add initial support for ethtool stats display Bhargava Marreddy
2026-02-23 19:52 ` Andrew Lunn
2026-02-24 19:50 ` Bhargava Chenna Marreddy
2026-02-24 21:13 ` Andrew Lunn
2026-02-26 16:28 ` Bhargava Chenna Marreddy
2026-02-23 16:36 ` [PATCH net-next 6/7] bng_en: periodically fetch and accumulate hardware statistics Bhargava Marreddy
2026-02-23 16:36 ` [PATCH net-next 7/7] bng_en: implement ndo_get_stats64 Bhargava Marreddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224183528.757e1174@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ajit.khaparde@broadcom$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=bhargava.marreddy@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
--cc=rajashekar.hudumula@broadcom$(echo .)com \
--cc=vikas.gupta@broadcom$(echo .)com \
--cc=vsrama-krishna.nemani@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox