From: Jakub Kicinski <kuba@kernel•org>
To: Inochi Amaoto <inochiama@gmail•com>
Cc: Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>, Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>, Yixun Lan <dlan@kernel•org>,
Maxime Coquelin <mcoquelin.stm32@gmail•com>,
Alexandre Torgue <alexandre.torgue@foss•st.com>,
Richard Cochran <richardcochran@gmail•com>,
Paul Walmsley <pjw@kernel•org>,
Palmer Dabbelt <palmer@dabbelt•com>,
Albert Ou <aou@eecs•berkeley.edu>,
Alexandre Ghiti <alex@ghiti•fr>,
"Russell King (Oracle)" <rmk+kernel@armlinux•org.uk>,
Yao Zi <me@ziyao•cc>, Yanteng Si <siyanteng@cqsoftware•com.cn>,
Choong Yong Liang <yong.liang.choong@linux•intel.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp•renesas.com>,
Shangjuan Wei <weishangjuan@eswincomputing•com>,
Chen-Yu Tsai <wens@kernel•org>,
Boon Khai Ng <boon.khai.ng@altera•com>,
Maxime Chevallier <maxime.chevallier@bootlin•com>,
Quentin Schulz <quentin.schulz@cherry•de>,
Giuseppe Cavallaro <peppe.cavallaro@st•com>,
Jose Abreu <joabreu@synopsys•com>,
netdev@vger•kernel.org, devicetree@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-riscv@lists•infradead.org,
spacemit@lists•linux.dev,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org, Yixun Lan <dlan@gentoo•org>,
Longbin Li <looong.bin@gmail•com>
Subject: Re: [PATCH net-next v5 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC
Date: Sat, 28 Feb 2026 13:18:45 -0800 [thread overview]
Message-ID: <20260228131845.70421792@kernel.org> (raw)
In-Reply-To: <20260227075718.2243818-4-inochiama@gmail.com>
On Fri, 27 Feb 2026 15:57:17 +0800 Inochi Amaoto wrote:
> The ethernet controller on Spacemit K3 SoC is Synopsys DesignWare
> MAC (version 5.40a), with the following special points:
> 1. The rate of the tx clock line is auto changed when the mac speed
> rate is changed, and no need for changing the input tx clock.
> 2. This controller require a extra syscon device to configure the
> interface type, enable wake up interrupt and delay configuration
> if needed.
checkpatch says:
ERROR: "foo* bar" should be "foo *bar"
#110: FILE: drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c:45:
+static int spacemit_dwmac_set_delay(struct spacmit_dwmac* dwmac,
ERROR: "foo* bar" should be "foo *bar"
#148: FILE: drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c:83:
+static int spacemit_dwmac_fix_delay(struct spacmit_dwmac* dwmac,
WARNING: line length of 99 exceeds 80 columns
#243: FILE: drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c:178:
+ apmu = syscon_regmap_lookup_by_phandle_args(pdev->dev.of_node, "spacemit,apmu", 2, offset);
--
pw-bot: cr
next prev parent reply other threads:[~2026-02-28 21:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 7:57 [PATCH net-next v5 0/3] riscv: spacemit: Add ethernet support for K3 Inochi Amaoto
2026-02-27 7:57 ` [PATCH net-next v5 1/3] dt-bindings: net: Add support for Spacemit K3 dwmac Inochi Amaoto
2026-02-27 7:57 ` [PATCH net-next v5 2/3] net: stmmac: platform: Add snps,dwmac-5.40a IP compatible string Inochi Amaoto
2026-02-27 7:57 ` [PATCH net-next v5 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC Inochi Amaoto
2026-02-28 21:18 ` Jakub Kicinski [this message]
2026-03-03 1:07 ` Inochi Amaoto
2026-03-02 13:08 ` [PATCH net-next v5 0/3] riscv: spacemit: Add ethernet support for K3 Emil Renner Berthing
2026-03-03 1:03 ` Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260228131845.70421792@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=alex@ghiti$(echo .)fr \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=boon.khai.ng@altera$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dlan@gentoo$(echo .)org \
--cc=dlan@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=inochiama@gmail$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=looong.bin@gmail$(echo .)com \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=me@ziyao$(echo .)cc \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=pjw@kernel$(echo .)org \
--cc=prabhakar.mahadev-lad.rj@bp$(echo .)renesas.com \
--cc=quentin.schulz@cherry$(echo .)de \
--cc=richardcochran@gmail$(echo .)com \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
--cc=robh@kernel$(echo .)org \
--cc=siyanteng@cqsoftware$(echo .)com.cn \
--cc=spacemit@lists$(echo .)linux.dev \
--cc=weishangjuan@eswincomputing$(echo .)com \
--cc=wens@kernel$(echo .)org \
--cc=yong.liang.choong@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox