From: Jakub Kicinski <kuba@kernel•org>
To: "Nitka, Grzegorz" <grzegorz.nitka@intel•com>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"intel-wired-lan@lists•osuosl.org"
<intel-wired-lan@lists•osuosl.org>,
"Oros, Petr" <poros@redhat•com>,
"richardcochran@gmail•com" <richardcochran@gmail•com>,
"andrew+netdev@lunn•ch" <andrew+netdev@lunn•ch>,
"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel•com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel•com>,
"Prathosh.Satish@microchip•com" <Prathosh.Satish@microchip•com>,
"Vecera, Ivan" <ivecera@redhat•com>,
"jiri@resnulli•us" <jiri@resnulli•us>,
"Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel•com>,
"vadim.fedorenko@linux•dev" <vadim.fedorenko@linux•dev>,
"donald.hunter@gmail•com" <donald.hunter@gmail•com>,
"horms@kernel•org" <horms@kernel•org>,
"pabeni@redhat•com" <pabeni@redhat•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"edumazet@google•com" <edumazet@google•com>
Subject: Re: [PATCH v12 net-next 0/8] dpll/ice: Add generic DPLL type and full TX reference clock control for E825
Date: Thu, 4 Jun 2026 15:54:22 -0700 [thread overview]
Message-ID: <20260604155422.167314ff@kernel.org> (raw)
In-Reply-To: <IA1PR11MB62197FC8E64BE92FBC108E6992102@IA1PR11MB6219.namprd11.prod.outlook.com>
On Thu, 4 Jun 2026 20:05:54 +0000 Nitka, Grzegorz wrote:
> > On Fri, 29 May 2026 16:26:20 +0200 Grzegorz Nitka wrote:
> > > NOTE: This series is intentionally submitted on net-next (not
> > > intel-wired-lan) as early feedback of DPLL subsystem changes is
> > > welcomed. In the past possible approaches were discussed in [1].
> >
> > I dug into 3 of the issues reported by Claude here and I think all
> > are really preexisting. But I don't see why we wouldn't fix those
> > first, and have a clean AI scan. Please send the fixes ASAP if you
> > have them, if they are trivial they may make it for tomorrow's PR.
>
> Thanks for your feedback.
> I'm not sure if I can identify exact 3 issues you mentioned above.
> I see couple pre-existing issues reported in
> https://sashiko.dev/#/patchset/20260529142628.1678955-1-grzegorz.nitka%40intel.com
> - 3 issues reported in [PATCH v12 net-next 3/8] dpll: extend pin notifier with notification source ID
> - 2 issues reported in [PATCH v12 net-next 5/8] ice: introduce TXC DPLL device and TX ref clock pin framework for E825
> The first one is false positive in my opinion.
>
> Did you mean those from patch 3/8?
> It should be rather simple ones. Shall I submit it as a part of this series?
> Or a new patch/patchset? (against next or net?)
Ugh, I think I missed that the caller looks at the ICE_FLAG_DPLL flag.
So most of the deinit bugs are not actually bugs.
You can add the fixes to this series.
next prev parent reply other threads:[~2026-06-04 22:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 14:26 [PATCH v12 net-next 0/8] dpll/ice: Add generic DPLL type and full TX reference clock control for E825 Grzegorz Nitka
2026-05-29 14:26 ` [PATCH v12 net-next 1/8] dpll: add generic DPLL type Grzegorz Nitka
2026-05-29 14:26 ` [PATCH v12 net-next 2/8] dpll: allow registering FW-identified pin with a different DPLL Grzegorz Nitka
2026-05-29 14:26 ` [PATCH v12 net-next 3/8] dpll: extend pin notifier with notification source ID Grzegorz Nitka
2026-05-29 14:26 ` [PATCH v12 net-next 4/8] dpll: allow fwnode pins to attempt state change without capability bit Grzegorz Nitka
2026-05-29 14:26 ` [PATCH v12 net-next 5/8] ice: introduce TXC DPLL device and TX ref clock pin framework for E825 Grzegorz Nitka
2026-05-29 14:26 ` [PATCH v12 net-next 6/8] ice: implement CPI support for E825C Grzegorz Nitka
2026-05-29 14:26 ` [PATCH v12 net-next 7/8] ice: add Tx reference clock index handling to AN restart command Grzegorz Nitka
2026-05-29 14:26 ` [PATCH v12 net-next 8/8] ice: implement E825 TX ref clock control and TXC hardware sync status Grzegorz Nitka
2026-06-04 1:30 ` [PATCH v12 net-next 0/8] dpll/ice: Add generic DPLL type and full TX reference clock control for E825 Jakub Kicinski
2026-06-04 20:05 ` Nitka, Grzegorz
2026-06-04 22:54 ` Jakub Kicinski [this message]
2026-06-05 16:10 ` Nitka, Grzegorz
2026-06-05 23:26 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604155422.167314ff@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=Prathosh.Satish@microchip$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=arkadiusz.kubalewski@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=grzegorz.nitka@intel$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=ivecera@redhat$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=poros@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox