* Re: linux-next: Tree for August 15 (bnx2) [resend/lost]
[not found] <20080815184032.3acd8032.sfr@canb.auug.org.au>
@ 2008-08-15 15:41 ` Randy Dunlap
2008-08-15 22:17 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2008-08-15 15:41 UTC (permalink / raw)
To: Stephen Rothwell, mchan, netdev; +Cc: linux-next, LKML
When VLAN is not enabled, bnx2 build fails with:
drivers/net/bnx2.c: In function 'bnx2_rx_int':
drivers/net/bnx2.c:2959: error: dereferencing pointer to incomplete type
drivers/net/bnx2.c:2960: error: dereferencing pointer to incomplete type
make[2]: *** [drivers/net/bnx2.o] Error 1
on these lines:
ve->h_vlan_proto = htons(ETH_P_8021Q);
ve->h_vlan_TCI = htons(vtag);
---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for August 15 (bnx2) [resend/lost]
2008-08-15 15:41 ` linux-next: Tree for August 15 (bnx2) [resend/lost] Randy Dunlap
@ 2008-08-15 22:17 ` David Miller
2008-08-15 23:41 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2008-08-15 22:17 UTC (permalink / raw)
To: randy.dunlap; +Cc: sfr, mchan, netdev, linux-next, linux-kernel
From: Randy Dunlap <randy.dunlap@oracle•com>
Date: Fri, 15 Aug 2008 08:41:16 -0700
> When VLAN is not enabled, bnx2 build fails with:
>
> drivers/net/bnx2.c: In function 'bnx2_rx_int':
> drivers/net/bnx2.c:2959: error: dereferencing pointer to incomplete type
> drivers/net/bnx2.c:2960: error: dereferencing pointer to incomplete type
> make[2]: *** [drivers/net/bnx2.o] Error 1
Does this fix it for you?
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index d454810..2486a65 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -35,8 +35,8 @@
#include <linux/time.h>
#include <linux/ethtool.h>
#include <linux/mii.h>
-#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
#include <linux/if_vlan.h>
+#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
#define BCM_VLAN 1
#endif
#include <net/ip.h>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for August 15 (bnx2) [resend/lost]
2008-08-15 22:17 ` David Miller
@ 2008-08-15 23:41 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2008-08-15 23:41 UTC (permalink / raw)
To: David Miller; +Cc: sfr, netdev, mchan, linux-kernel, linux-next
--- Original Message ---
> From: Randy Dunlap <randy.dunlap@oracle•com>
> Date: Fri, 15 Aug 2008 08:41:16 -0700
>
> > When VLAN is not enabled, bnx2 build fails with:
> >
> > drivers/net/bnx2.c: In function 'bnx2_rx_int':
> > drivers/net/bnx2.c:2959: error: dereferencing pointer to incomplete type
> > drivers/net/bnx2.c:2960: error: dereferencing pointer to incomplete type
> > make[2]: *** [drivers/net/bnx2.o] Error 1
>
> Does this fix it for you?
Yes, it does. Thanks.
> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
> index d454810..2486a65 100644
> --- a/drivers/net/bnx2.c
> +++ b/drivers/net/bnx2.c
> @@ -35,8 +35,8 @@
> #include <linux/time.h>
> #include <linux/ethtool.h>
> #include <linux/mii.h>
> -#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
> #include <linux/if_vlan.h>
> +#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
> #define BCM_VLAN 1
> #endif
> #include <net/ip.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-08-15 23:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20080815184032.3acd8032.sfr@canb.auug.org.au>
2008-08-15 15:41 ` linux-next: Tree for August 15 (bnx2) [resend/lost] Randy Dunlap
2008-08-15 22:17 ` David Miller
2008-08-15 23:41 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox