From: Arnd Bergmann <arnd@arndb•de>
To: Thomas Gleixner <tglx@linutronix•de>
Cc: David Miller <davem@davemloft•net>,
linux-kernel@vger•kernel.org, peterz@infradead•org,
mingo@kernel•org, dingtianhong@huawei•com,
zhangfei.gao@linaro•org, dan.carpenter@oracle•com,
netdev@vger•kernel.org
Subject: Re: [patch v2] net: hip04: Make tx coalesce timer actually work
Date: Wed, 15 Apr 2015 12:20:01 +0200 [thread overview]
Message-ID: <2657074.k4FFdZD9ci@wuerfel> (raw)
In-Reply-To: <alpine.DEB.2.11.1504142140290.3845@nanos>
On Tuesday 14 April 2015 21:42:42 Thomas Gleixner wrote:
> The code sets the expiry value of the timer to a relative value and
> starts it with hrtimer_start_expires. That's fine, but that only works
> once. The timer is started in relative mode, so the expiry value gets
> overwritten with the absolut expiry time (now + expiry).
>
> So once the timer expired, a new call to hrtimer_start_expires results
> in an immidiately expired timer, because the expiry value is
> already in the past.
>
> Use the proper mechanisms to (re)start the timer in the intended way.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix•de>
> Cc: "David S. Miller" <davem@davemloft•net>
> Cc: dingtianhong <dingtianhong@huawei•com>
> Cc: Arnd Bergmann <arnd@arndb•de>
> Cc: Zhangfei Gao <zhangfei.gao@linaro•org>
> Cc: Dan Carpenter <dan.carpenter@oracle•com>
> Cc: netdev@vger•kernel.org
>
Acked-by: Arnd Bergmann <arnd@arndb•de>
next prev parent reply other threads:[~2015-04-15 10:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150413210009.682000343@linutronix.de>
2015-04-13 21:02 ` [patch 4/5] net: hip04: Make tx coalesce timer actually work Thomas Gleixner
2015-04-13 21:24 ` Arnd Bergmann
2015-04-13 21:42 ` Thomas Gleixner
2015-04-13 22:03 ` Arnd Bergmann
2015-04-13 22:08 ` Thomas Gleixner
2015-04-14 7:53 ` Ding Tianhong
2015-04-14 18:15 ` David Miller
2015-04-14 19:42 ` [patch v2] " Thomas Gleixner
2015-04-15 2:24 ` Ding Tianhong
2015-04-15 10:20 ` Arnd Bergmann [this message]
2015-04-15 21:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2657074.k4FFdZD9ci@wuerfel \
--to=arnd@arndb$(echo .)de \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dingtianhong@huawei$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mingo@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=zhangfei.gao@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox