From: Arnd Bergmann <arnd@arndb•de>
To: Thomas Gleixner <tglx@linutronix•de>
Cc: LKML <linux-kernel@vger•kernel.org>,
Peter Zijlstra <peterz@infradead•org>,
Ingo Molnar <mingo@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
dingtianhong <dingtianhong@huawei•com>,
Zhangfei Gao <zhangfei.gao@linaro•org>,
Dan Carpenter <dan.carpenter@oracle•com>,
netdev@vger•kernel.org
Subject: Re: [patch 4/5] net: hip04: Make tx coalesce timer actually work
Date: Tue, 14 Apr 2015 00:03:12 +0200 [thread overview]
Message-ID: <3040901.Bp3bfgc1te@wuerfel> (raw)
In-Reply-To: <alpine.DEB.2.11.1504132338080.3845@nanos>
On Monday 13 April 2015 23:42:03 Thomas Gleixner wrote:
> >
> > Question: this looks to me like it sets both the minimum and maximum
> > time to priv->tx_coalesce_usecs/2, when the intention was to set
> > the minimum to priv->tx_coalesce_usecs/2 and the maximum to
> > priv->tx_coalesce_usecs. Am I missing something subtle here, or did
> > you just misread my original intention from the botched code?
>
> Yes, I missed that. Simple fix for this is:
>
> unsigned long t_ns = priv->tx_coalesce_usecs * NSEC_PER_USEC / 2;
>
> hrtimer_start_range_ns(&priv->tx_coalesce_timer, ns_to_ktime(t_ns),
> t_ns, HRTIMER_MODE_REL);
Ah, good. I have to admit that I'd probably make the same mistake
again if I was to do this for another driver and you hadn't sent
the fix. The hrtimer_set_expires_range() function just looked like
it had been designed for the use case I was interested in ;-).
Any idea how to prevent the next person from making the same mistake?
Arnd
next prev parent reply other threads:[~2015-04-13 22:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150413210009.682000343@linutronix.de>
2015-04-13 21:02 ` [patch 4/5] net: hip04: Make tx coalesce timer actually work Thomas Gleixner
2015-04-13 21:24 ` Arnd Bergmann
2015-04-13 21:42 ` Thomas Gleixner
2015-04-13 22:03 ` Arnd Bergmann [this message]
2015-04-13 22:08 ` Thomas Gleixner
2015-04-14 7:53 ` Ding Tianhong
2015-04-14 18:15 ` David Miller
2015-04-14 19:42 ` [patch v2] " Thomas Gleixner
2015-04-15 2:24 ` Ding Tianhong
2015-04-15 10:20 ` Arnd Bergmann
2015-04-15 21:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3040901.Bp3bfgc1te@wuerfel \
--to=arnd@arndb$(echo .)de \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dingtianhong@huawei$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mingo@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=zhangfei.gao@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox