From: Oliver Neukum <oneukum@suse•de>
To: Alexey ORISHKO <alexey.orishko@stericsson•com>
Cc: "Bjørn Mork" <bjorn@mork•no>,
"Alexey Orishko" <alexey.orishko@gmail•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-usb@vger•kernel.org" <linux-usb@vger•kernel.org>,
"Greg Suarez" <gsuarez@smithmicro•com>
Subject: Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union
Date: Tue, 22 Jan 2013 10:32:28 +0100 [thread overview]
Message-ID: <3625170.qHSC1Z5vti@linux-5eaq.site> (raw)
In-Reply-To: <2AC7D4AD8BA1C640B4C60C61C8E520154A8EE17D8E@EXDCVYMBSTM006.EQ1STM.local>
On Monday 21 January 2013 18:59:05 Alexey ORISHKO wrote:
> > > Either the FLAG_MULTI_PACKET minidriver will have already padded the
> > > buffer so that we do not hit (length % dev->maxpacket == 0), or we
> > > should choose one of the alternatives: ZLP or padding.
> >
> > But we cannot simply call __skb_put for a complicated data frame.
> > Besides you may want the current behavior.
> >
>
> Specification says:
> NCM/MBIM shall not send ZLP if buffer size is dwNtbOutMaxSize.
Hi,
one thing on a generic level, which I hope you don't take wrong, but I need
to make it clear. Usbnet is for every driver. What a spec says
or what the reality of implementations of that spec looks like, determine
what usbnet needs to support.
But what is not needed to implement that spec doesn't matter in deciding
what usbnet needs not support. Drivers may or may not need ZLPs.
Regards
Oliver
next prev parent reply other threads:[~2013-01-22 9:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 14:25 [PATCH net] net: cdc_ncm: workaround for missing CDC Union Bjørn Mork
[not found] ` <1358519147-10073-1-git-send-email-bjorn-yOkvZcmFvRU@public.gmane.org>
2013-01-18 19:11 ` Oliver Neukum
[not found] ` <22276933.xSGyXJfOvq-7ztolUikljGernLeA6q8OA@public.gmane.org>
2013-01-18 21:17 ` Bjørn Mork
2013-01-20 0:21 ` Alexey Orishko
[not found] ` <CAL_Kpj1B=_+eN3Y0n3d9_r4JoeHD2LQFSU+b+taCZL0G4icu6A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-21 8:31 ` Bjørn Mork
2013-01-21 14:08 ` Bjørn Mork
2013-01-21 14:47 ` Bjørn Mork
[not found] ` <87mww2y4ni.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2013-01-21 14:55 ` Oliver Neukum
2013-01-21 15:28 ` Bjørn Mork
[not found] ` <87ip6qy2q7.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2013-01-22 8:50 ` Oliver Neukum
2013-01-22 10:35 ` Bjørn Mork
2013-01-21 17:59 ` Alexey ORISHKO
2013-01-22 9:07 ` Oliver Neukum
2013-01-22 9:32 ` Oliver Neukum [this message]
2013-01-19 12:18 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3625170.qHSC1Z5vti@linux-5eaq.site \
--to=oneukum@suse$(echo .)de \
--cc=alexey.orishko@gmail$(echo .)com \
--cc=alexey.orishko@stericsson$(echo .)com \
--cc=bjorn@mork$(echo .)no \
--cc=gsuarez@smithmicro$(echo .)com \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox