From: "Bjørn Mork" <bjorn@mork•no>
To: Oliver Neukum <oneukum@suse•de>
Cc: Alexey Orishko <alexey.orishko@gmail•com>,
netdev@vger•kernel.org, linux-usb@vger•kernel.org,
Greg Suarez <gsuarez@smithmicro•com>,
Alexey Orishko <alexey.orishko@stericsson•com>
Subject: Re: [PATCH net] net: cdc_ncm: workaround for missing CDC Union
Date: Tue, 22 Jan 2013 11:35:48 +0100 [thread overview]
Message-ID: <87d2wxa4jf.fsf@nemi.mork.no> (raw)
In-Reply-To: <6132136.Whp52cipJH@linux-5eaq.site> (Oliver Neukum's message of "Tue, 22 Jan 2013 09:50:39 +0100")
Oliver Neukum <oneukum@suse•de> writes:
> On Monday 21 January 2013 16:28:48 Bjørn Mork wrote:
>
>> Agreed. But I believe the condition should be
>>
>> if (!(info->flags & FLAG_SEND_ZLP) && !(info->flags & FLAG_MULTI_PACKET)) {
>> ..
>> } else {
>> urb->transfer_flags |= URB_ZERO_PACKET;
>> }
>>
>> to ensure that we send the ZLP in this case.
>
> Why? If a driver wants ZLP, it can set FLAG_SEND_ZLP. Your proposed change
> would take away an option from drivers without any gain.
OK.
Bjørn
next prev parent reply other threads:[~2013-01-22 10:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 14:25 [PATCH net] net: cdc_ncm: workaround for missing CDC Union Bjørn Mork
[not found] ` <1358519147-10073-1-git-send-email-bjorn-yOkvZcmFvRU@public.gmane.org>
2013-01-18 19:11 ` Oliver Neukum
[not found] ` <22276933.xSGyXJfOvq-7ztolUikljGernLeA6q8OA@public.gmane.org>
2013-01-18 21:17 ` Bjørn Mork
2013-01-20 0:21 ` Alexey Orishko
[not found] ` <CAL_Kpj1B=_+eN3Y0n3d9_r4JoeHD2LQFSU+b+taCZL0G4icu6A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-21 8:31 ` Bjørn Mork
2013-01-21 14:08 ` Bjørn Mork
2013-01-21 14:47 ` Bjørn Mork
[not found] ` <87mww2y4ni.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2013-01-21 14:55 ` Oliver Neukum
2013-01-21 15:28 ` Bjørn Mork
[not found] ` <87ip6qy2q7.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2013-01-22 8:50 ` Oliver Neukum
2013-01-22 10:35 ` Bjørn Mork [this message]
2013-01-21 17:59 ` Alexey ORISHKO
2013-01-22 9:07 ` Oliver Neukum
2013-01-22 9:32 ` Oliver Neukum
2013-01-19 12:18 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2wxa4jf.fsf@nemi.mork.no \
--to=bjorn@mork$(echo .)no \
--cc=alexey.orishko@gmail$(echo .)com \
--cc=alexey.orishko@stericsson$(echo .)com \
--cc=gsuarez@smithmicro$(echo .)com \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oneukum@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox