From: Subash Abhinov Kasiviswanathan <subashab@codeaurora•org>
To: Jiri Pirko <jiri@resnulli•us>
Cc: netdev@vger•kernel.org, davem@davemloft•net,
fengguang.wu@intel•com, dcbw@redhat•com,
stephen@networkplumber•org
Subject: Re: [PATCH net-next 3/3 v4] drivers: net: ethernet: qualcomm: rmnet: Initial implementation
Date: Wed, 16 Aug 2017 11:46:48 -0600 [thread overview]
Message-ID: <3cff6f8152b3390f0fc137549c72345a@codeaurora.org> (raw)
In-Reply-To: <20170816113017.GJ1868@nanopsycho>
>> +struct rmnet_phys_ep_conf_s {
>
> The name is cryptic. Why "_s"?
>> +
>> +struct rmnet_vnd_private_s {
>
> Again, cryptic.
>
>
>> + struct rmnet_logical_ep_conf_s local_ep;
>> + u32 msg_enable;
>> +};
Hi Jiri
The _s was to indicate struct. I'll remove that.
>> +rx_handler_result_t rmnet_ingress_handler(struct sk_buff *skb)
>> +{
>> + struct rmnet_phys_ep_conf_s *config;
>
> I still fail to understand why the name of this is "config". Please
> change to something else across whole code. Including the name of the
> struct.
>
>> + struct net_device *dev;
>> + int rc;
>> +
>> + if (!skb)
>> + return RX_HANDLER_CONSUMED;
>> +
>> + dev = skb->dev;
>> + config = rmnet_get_phys_ep_config(skb->dev);
>
> You have dev. Why not use dev?
>
>> +rx_handler_result_t rmnet_rx_handler(struct sk_buff **pskb)
>> +{
>> + return rmnet_ingress_handler(*pskb);
>
> This is just silly. Why you don't have the content of
> rmnet_ingress_handler
> right here?
I'll make these changes now.
prev parent reply other threads:[~2017-08-16 17:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 4:15 [PATCH net-next 0/3 v4] Add support for rmnet driver Subash Abhinov Kasiviswanathan
2017-08-16 4:15 ` [PATCH net-next 1/3 v4] net: ether: Add support for multiplexing and aggregation type Subash Abhinov Kasiviswanathan
2017-08-16 4:15 ` [PATCH net-next 2/3 v4] net: arp: Add support for raw IP device Subash Abhinov Kasiviswanathan
2017-08-16 4:52 ` Marcel Holtmann
2017-08-17 0:59 ` Subash Abhinov Kasiviswanathan
2017-08-16 4:15 ` [PATCH net-next 3/3 v4] drivers: net: ethernet: qualcomm: rmnet: Initial implementation Subash Abhinov Kasiviswanathan
2017-08-16 4:24 ` David Miller
2017-08-16 11:08 ` David Laight
2017-08-16 17:38 ` Subash Abhinov Kasiviswanathan
2017-08-16 11:30 ` Jiri Pirko
2017-08-16 17:46 ` Subash Abhinov Kasiviswanathan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cff6f8152b3390f0fc137549c72345a@codeaurora.org \
--to=subashab@codeaurora$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dcbw@redhat$(echo .)com \
--cc=fengguang.wu@intel$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox