From: Maarten Lankhorst <m.b.lankhorst@gmail•com>
To: Jiri Benc <jbenc@suse•cz>
Cc: Johannes Berg <johannes@sipsolutions•net>,
"John W. Linville" <linville@tuxdriver•com>,
netdev <netdev@vger•kernel.org>,
mb@bu3sch•de
Subject: Re: [PATCH] Remove CONFIG_NET_WIRELESS
Date: Mon, 15 Jan 2007 20:24:21 +0100 [thread overview]
Message-ID: <45ABD4E5.6040707@gmail.com> (raw)
In-Reply-To: <20070115154008.0dedf451@griffin.suse.cz>
Jiri Benc schreef:
> On Mon, 15 Jan 2007 13:31:06 +0000, Johannes Berg wrote:
>
>> On Mon, 2007-01-15 at 13:55 +0100, Maarten Lankhorst wrote:
>>
>>> Enabling this doesn't cause anything to fail, but my wireless router
>>> doesn't have a pci bus, but instead a native SSB, so CONFIG_NET_WIRELESS
>>> isn't selected. This in turn causes wext-common.o to not be built, so I
>>> get missing symbols and a build breakage. That's why I made
>>> wext-common.o depend on CONFIG_WIRELESS_EXT instead of
>>> CONFIG_NET_WIRELESS. Since nothing else uses CONFIG_NET_WIRELESS I
>>> decided to kill that symbol.
>>>
>> Ok, that makes sense to me. Let's put this in but with this better
>> description rather than the original one.
>>
>
> The original mail with patch apparently didn't get to netdev (I haven't
> received it and it's not in netdev archive). Maarten, could you resend
> it please?
>
> Thanks,
>
> Jiri
>
>
Sorry, must have missed sending it to netdev, original message follows.
Remove CONFIG_NET_WIRELESS
Nothing uses this, and it breaks the kernel build if a wireless device is used with a unsupported type of bus.
Verified this with a grep.
Signed-off-by: Maarten Lankhorst <m.b.lankhorst@gmail•com>
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index 03dbe60..b9620c6 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -544,11 +544,5 @@ source "drivers/net/wireless/zd1211rw/Kc
source "drivers/net/wireless/d80211/Kconfig"
-# yes, this works even when no drivers are selected
-config NET_WIRELESS
- bool
- depends on NET_RADIO && (ISA || PCI || PPC_PMAC || PCMCIA)
- default y
-
endmenu
diff --git a/net/wireless/Makefile b/net/wireless/Makefile
index f285440..44ae23a 100644
--- a/net/wireless/Makefile
+++ b/net/wireless/Makefile
@@ -12,5 +12,5 @@ obj-ny :=
# this needs to be compiled in...
obj-$(CONFIG_CFG80211_WEXT_COMPAT) += wext-compat.o
-obj-$(CONFIG_CFG80211_WEXT_COMPAT)$(CONFIG_NET_WIRELESS) += wext-common.o
+obj-$(CONFIG_CFG80211_WEXT_COMPAT)$(CONFIG_WIRELESS_EXT) += wext-common.o
obj-y += $(obj-yy) $(obj-yn) $(obj-ny)
prev parent reply other threads:[~2007-01-15 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <45A91414.40107@gmail.com>
2007-01-15 11:24 ` [PATCH] Remove CONFIG_NET_WIRELESS Johannes Berg
2007-01-15 12:55 ` Maarten Lankhorst
2007-01-15 13:31 ` Johannes Berg
2007-01-15 14:40 ` Jiri Benc
2007-01-15 19:24 ` Maarten Lankhorst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ABD4E5.6040707@gmail.com \
--to=m.b.lankhorst@gmail$(echo .)com \
--cc=jbenc@suse$(echo .)cz \
--cc=johannes@sipsolutions$(echo .)net \
--cc=linville@tuxdriver$(echo .)com \
--cc=mb@bu3sch$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox