From: Maarten Lankhorst <m.b.lankhorst@gmail•com>
To: Johannes Berg <johannes@sipsolutions•net>
Cc: "John W. Linville" <linville@tuxdriver•com>,
netdev <netdev@vger•kernel.org>,
mb@bu3sch•de
Subject: Re: [PATCH] Remove CONFIG_NET_WIRELESS
Date: Mon, 15 Jan 2007 13:55:45 +0100 [thread overview]
Message-ID: <45AB79D1.2070002@gmail.com> (raw)
In-Reply-To: <1168860268.3344.0.camel@johannes.berg>
Johannes Berg schreef:
> On Sat, 2007-01-13 at 18:17 +0100, Maarten Lankhorst wrote:
>
>> Remove CONFIG_NET_WIRELESS
>> Nothing uses this, and it breaks the kernel build if a wireless device is used with a unsupported type of bus.
>> Verified this with a grep.
>>
>
> I don't really care about the symbol and I'm in favour of removing it if
> it is useless, but I don't understand the rationale. How does enabling
> this cause anything to fail?
>
> johannes
>
Enabling this doesn't cause anything to fail, but my wireless router
doesn't have a pci bus, but instead a native SSB, so CONFIG_NET_WIRELESS
isn't selected. This in turn causes wext-common.o to not be built, so I
get missing symbols and a build breakage. That's why I made
wext-common.o depend on CONFIG_WIRELESS_EXT instead of
CONFIG_NET_WIRELESS. Since nothing else uses CONFIG_NET_WIRELESS I
decided to kill that symbol.
maarten
next prev parent reply other threads:[~2007-01-15 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <45A91414.40107@gmail.com>
2007-01-15 11:24 ` [PATCH] Remove CONFIG_NET_WIRELESS Johannes Berg
2007-01-15 12:55 ` Maarten Lankhorst [this message]
2007-01-15 13:31 ` Johannes Berg
2007-01-15 14:40 ` Jiri Benc
2007-01-15 19:24 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45AB79D1.2070002@gmail.com \
--to=m.b.lankhorst@gmail$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=linville@tuxdriver$(echo .)com \
--cc=mb@bu3sch$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox