From: Jeff Garzik <jgarzik@pobox•com>
To: Stephen Hemminger <shemminger@linux-foundation•org>
Cc: "David S. Miller" <davem@davemloft•net>,
Ramkrishna Vepa <ram.vepa@neterion•com>,
Raapur Santosh <santosh.rastapur@neterion•com>,
Sivakumar Subramani <sivakumar.subramani@neterion•com>,
Sreenivasa Honnur <sreenivasa.honnur@neterion•com>,
netdev@vger•kernel.org
Subject: Re: [PATCH net-2.6.24] s2io: sparse warnings fix
Date: Fri, 05 Oct 2007 13:51:51 -0400 [thread overview]
Message-ID: <470679B7.2060901@pobox.com> (raw)
In-Reply-To: <20071005090725.09a80bc7@freepuppy.rosehill>
Stephen Hemminger wrote:
> Fix warnings from sparse checker about shadowed definition and improperly
> formatted ethtool_strings.
>
> I chose to change module parameter rather than uglify the code by changing
> the variable name.
Changing the name of existing module parameters can potentially
introduce breakage in the field.
Additionally, we have module_param_named() to account for this sort of
thing, where the module parameter name differs from the internal
variable name.
The rest looks OK.
Please resend, potentially moving the module parameter change(s) into a
separate patch.
next prev parent reply other threads:[~2007-10-05 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-05 16:07 [PATCH net-2.6.24] s2io: sparse warnings fix Stephen Hemminger
2007-10-05 17:51 ` Jeff Garzik [this message]
2007-10-05 19:39 ` [PATCH net-2.6.24] s2io: sparse warnings fix (rev2) Stephen Hemminger
2007-10-11 1:27 ` Ramkrishna Vepa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470679B7.2060901@pobox.com \
--to=jgarzik@pobox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ram.vepa@neterion$(echo .)com \
--cc=santosh.rastapur@neterion$(echo .)com \
--cc=shemminger@linux-foundation$(echo .)org \
--cc=sivakumar.subramani@neterion$(echo .)com \
--cc=sreenivasa.honnur@neterion$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox