From: Eric Dumazet <dada1@cosmosbay•com>
To: Wang Chen <wangchen@cn•fujitsu.com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] IPV4: add raw drops counter
Date: Tue, 13 Nov 2007 12:11:17 +0100 [thread overview]
Message-ID: <47398655.4060400@cosmosbay.com> (raw)
In-Reply-To: <47397514.2070002@cn.fujitsu.com>
Wang Chen a écrit :
> Add raw drops counter for IPv4 in /proc/net/raw .
>
> Signed-off-by: Wang Chen <wangchen@cn•fujitsu.com>
> ---
> include/net/sock.h | 2 ++
> net/core/sock.c | 1 +
> net/ipv4/raw.c | 16 +++++++++-------
> 3 files changed, 12 insertions(+), 7 deletions(-)
>
> diff -Nurp linux-2.6.24-rc2.org/include/net/sock.h linux-2.6.24-rc2/include/net/sock.h
> --- linux-2.6.24-rc2.org/include/net/sock.h 2007-11-09 16:37:08.000000000 +0800
> +++ linux-2.6.24-rc2/include/net/sock.h 2007-11-13 15:19:20.000000000 +0800
> @@ -156,6 +156,7 @@ struct sock_common {
> * @sk_prot_creator: sk_prot of original sock creator (see ipv6_setsockopt, IPV6_ADDRFORM for instance)
> * @sk_err: last error
> * @sk_err_soft: errors that don't cause failure but are the cause of a persistent failure not just 'timed out'
> + * @sk_drops: raw drops counter
> * @sk_ack_backlog: current listen backlog
> * @sk_max_ack_backlog: listen backlog set in listen()
> * @sk_priority: %SO_PRIORITY setting
> @@ -239,6 +240,7 @@ struct sock {
> rwlock_t sk_callback_lock;
> int sk_err,
> sk_err_soft;
> + atomic_t sk_drops;
>
This doesnt need an atomic_t , just an 'unsigned int' is OK, since
sock_queue_rcv_skb() is called on a locked socket.
Also, I suggest doing the sk_drops increment in sock_queue_rcv_skb() so
that it can be used for other sockets as well ?
I like having this counter per socket, but only if an application can
retrieve its value with a getsockopt() call, dont you think ?
getsockopt(sock, SOL_SOCKET, SO_DROPSCNT, &val, &vallen);
next prev parent reply other threads:[~2007-11-13 11:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 9:57 [PATCH] IPV4: add raw drops counter Wang Chen
2007-11-13 11:11 ` Eric Dumazet [this message]
2007-11-14 1:27 ` Wang Chen
2007-11-14 6:00 ` Eric Dumazet
2007-11-14 3:12 ` [PATCH 1/2] SOCK: " Wang Chen
2007-11-14 3:15 ` [PATCH 2/2] SOCK: add raw6 " Wang Chen
2007-11-14 4:31 ` David Miller
2007-11-14 4:50 ` Wang Chen
2007-11-14 5:48 ` Eric Dumazet
2007-11-14 6:45 ` Wang Chen
2007-11-14 4:30 ` [PATCH 1/2] SOCK: add raw " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47398655.4060400@cosmosbay.com \
--to=dada1@cosmosbay$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=wangchen@cn$(echo .)fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox