From: Wang Chen <wangchen@cn•fujitsu.com>
To: Eric Dumazet <dada1@cosmosbay•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH 2/2] SOCK: add raw6 drops counter
Date: Wed, 14 Nov 2007 14:45:33 +0800 [thread overview]
Message-ID: <473A998D.8050101@cn.fujitsu.com> (raw)
In-Reply-To: <473A8C2B.2040709@cosmosbay.com>
Eric Dumazet said the following on 2007-11-14 13:48:
>> diff -Nurp linux-2.6.24-rc2.org/net/ipv6/raw.c
>> linux-2.6.24-rc2/net/ipv6/raw.c
>> --- linux-2.6.24-rc2.org/net/ipv6/raw.c 2007-11-09
>> 16:38:05.000000000 +0800
>> +++ linux-2.6.24-rc2/net/ipv6/raw.c 2007-11-14 09:46:54.000000000
>> +0800
>> @@ -354,14 +354,14 @@ static inline int rawv6_rcv_skb(struct s
>> {
>> if ((raw6_sk(sk)->checksum || sk->sk_filter) &&
>> skb_checksum_complete(skb)) {
>> - /* FIXME: increment a raw6 drops counter here */
>> + atomic_inc(&sk->sk_drops);
>
> I am not sure the comment was refering to a per socket counter here.
>
> If the frame checksum is bad, we can not be sure the socket is OK, since
> the garbaged bits could be in the tuple that identify the socket.
>
> Maybe here we want to increment a global raw6 drop counter (well, for
> the given ipv6 instance)
>
What the /proc/net/raw6 shows is statistical information about raw socket
in IPv6 stack. And the information is per socket per row.
So I think it's better to count it to per socket.
next prev parent reply other threads:[~2007-11-14 6:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 9:57 [PATCH] IPV4: add raw drops counter Wang Chen
2007-11-13 11:11 ` Eric Dumazet
2007-11-14 1:27 ` Wang Chen
2007-11-14 6:00 ` Eric Dumazet
2007-11-14 3:12 ` [PATCH 1/2] SOCK: " Wang Chen
2007-11-14 3:15 ` [PATCH 2/2] SOCK: add raw6 " Wang Chen
2007-11-14 4:31 ` David Miller
2007-11-14 4:50 ` Wang Chen
2007-11-14 5:48 ` Eric Dumazet
2007-11-14 6:45 ` Wang Chen [this message]
2007-11-14 4:30 ` [PATCH 1/2] SOCK: add raw " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473A998D.8050101@cn.fujitsu.com \
--to=wangchen@cn$(echo .)fujitsu.com \
--cc=dada1@cosmosbay$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox