From: Chris Leech <christopher.leech@intel•com>
To: Christoph Hellwig <hch@infradead•org>
Cc: "Love, Robert W" <robert.w.love@intel•com>,
linux-scsi@vger•kernel.org, "Waskiewicz Jr,
Peter P" <peter.p.waskiewicz.jr@intel•com>,
devel@open-fcoe•org, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org, Rob Love <robert.w.love@linux•intel.com>,
"Zou, Yi" <yi.zou@intel•com>, "Dev, Vasu" <vasu.dev@intel•com>,
james.bottomley@hansenpartnership•com, davem@davemloft•net,
jeff@garzik•org, "Kok, Auke-jan H" <auke-jan.h.kok@intel•com>,
"Ronciak, John" <john.ronciak@intel•com>,
"Van De Ven, Arjan" <arjan.van.de.ven@intel•com>,
Mike Christie <michaelc@cs•wisc.edu>
Subject: Re: [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project
Date: Wed, 28 Nov 2007 09:53:52 -0800 [thread overview]
Message-ID: <474DAB30.20703@intel.com> (raw)
In-Reply-To: <20071128074426.GA30468@infradead.org>
Christoph Hellwig wrote:
> I just did a very quick glance over the tree. Some extremly highlevel
> comments to start with before actually starting the source review:
Thanks for taking a look Christoph
> - why do you need your own libcrc? lib/crc32.c has a crc32_le
We shouldn't, but we may want to add a CRC and copy routine.
> - libsa should go. Much of it is just wrappers of kernel functions
> that should be used directly. Other like that hash, even or state
> helpers might either be opencoded in the caller or made completely
> generic in lib/. Probably the former but we'll have to see.
Yes, and along with it the last use of the BSD TAILQ macros. Just
before Rob set up the open repos I finished converting most of those to
list_head, the only one left is in the sa_event mechanism. Rather than
convert it I'd like to replace the use of sa_event with notifier call
chains. I just need to finish auditing the use to make sure the
differences won't cause unexpected problems.
After than and unwrapping kernel functions, I think the only thing left
before completly removing libsa is to open code the state machines.
Similarly I think net_types.h need to go.
- Chris
next prev parent reply other threads:[~2007-11-28 18:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 18:49 [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project Love, Robert W
2007-11-28 7:44 ` Christoph Hellwig
2007-11-28 17:53 ` Chris Leech [this message]
2007-11-28 20:08 ` [Open-FCoE] " Joe Eykholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474DAB30.20703@intel.com \
--to=christopher.leech@intel$(echo .)com \
--cc=arjan.van.de.ven@intel$(echo .)com \
--cc=auke-jan.h.kok@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devel@open-fcoe$(echo .)org \
--cc=hch@infradead$(echo .)org \
--cc=james.bottomley@hansenpartnership$(echo .)com \
--cc=jeff@garzik$(echo .)org \
--cc=john.ronciak@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=michaelc@cs$(echo .)wisc.edu \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peter.p.waskiewicz.jr@intel$(echo .)com \
--cc=robert.w.love@intel$(echo .)com \
--cc=robert.w.love@linux$(echo .)intel.com \
--cc=vasu.dev@intel$(echo .)com \
--cc=yi.zou@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox