* [patch 02/17] qla3xxx: convert byte order of constant instead of variable
@ 2008-03-04 23:19 akpm
2008-03-26 4:36 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2008-03-04 23:19 UTC (permalink / raw)
To: jeff; +Cc: netdev, akpm, marcin.slusarz, ron.mercer
From: Marcin Slusarz <marcin.slusarz@gmail•com>
Convert byte order of constant instead of variable which can be done at
compile time (vs run time)
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail•com>
Acked-by: Ron Mercer <ron.mercer@qlogic•com>
Signed-off-by: Andrew Morton <akpm@linux-foundation•org>
---
drivers/net/qla3xxx.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff -puN drivers/net/qla3xxx.c~qla3xxx-convert-byte-order-of-constant-instead-of-variable drivers/net/qla3xxx.c
--- a/drivers/net/qla3xxx.c~qla3xxx-convert-byte-order-of-constant-instead-of-variable
+++ a/drivers/net/qla3xxx.c
@@ -2472,8 +2472,7 @@ static int ql_send_map(struct ql3_adapte
if (seg_cnt == 1) {
/* Terminate the last segment. */
- oal_entry->len =
- cpu_to_le32(le32_to_cpu(oal_entry->len) | OAL_LAST_ENTRY);
+ oal_entry->len |= cpu_to_le32(OAL_LAST_ENTRY);
} else {
oal = tx_cb->oal;
for (completed_segs=0; completed_segs<frag_cnt; completed_segs++,seg++) {
@@ -2530,8 +2529,7 @@ static int ql_send_map(struct ql3_adapte
frag->size);
}
/* Terminate the last segment. */
- oal_entry->len =
- cpu_to_le32(le32_to_cpu(oal_entry->len) | OAL_LAST_ENTRY);
+ oal_entry->len |= cpu_to_le32(OAL_LAST_ENTRY);
}
return NETDEV_TX_OK;
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 02/17] qla3xxx: convert byte order of constant instead of variable
2008-03-04 23:19 [patch 02/17] qla3xxx: convert byte order of constant instead of variable akpm
@ 2008-03-26 4:36 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-03-26 4:36 UTC (permalink / raw)
To: akpm; +Cc: netdev, marcin.slusarz, ron.mercer
akpm@linux-foundation•org wrote:
> From: Marcin Slusarz <marcin.slusarz@gmail•com>
>
> Convert byte order of constant instead of variable which can be done at
> compile time (vs run time)
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail•com>
> Acked-by: Ron Mercer <ron.mercer@qlogic•com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation•org>
> ---
>
> drivers/net/qla3xxx.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff -puN drivers/net/qla3xxx.c~qla3xxx-convert-byte-order-of-constant-instead-of-variable drivers/net/qla3xxx.c
> --- a/drivers/net/qla3xxx.c~qla3xxx-convert-byte-order-of-constant-instead-of-variable
> +++ a/drivers/net/qla3xxx.c
> @@ -2472,8 +2472,7 @@ static int ql_send_map(struct ql3_adapte
>
> if (seg_cnt == 1) {
> /* Terminate the last segment. */
> - oal_entry->len =
> - cpu_to_le32(le32_to_cpu(oal_entry->len) | OAL_LAST_ENTRY);
> + oal_entry->len |= cpu_to_le32(OAL_LAST_ENTRY);
> } else {
> oal = tx_cb->oal;
> for (completed_segs=0; completed_segs<frag_cnt; completed_segs++,seg++) {
> @@ -2530,8 +2529,7 @@ static int ql_send_map(struct ql3_adapte
> frag->size);
> }
> /* Terminate the last segment. */
> - oal_entry->len =
> - cpu_to_le32(le32_to_cpu(oal_entry->len) | OAL_LAST_ENTRY);
> + oal_entry->len |= cpu_to_le32(OAL_LAST_ENTRY);
> }
>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-26 4:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-04 23:19 [patch 02/17] qla3xxx: convert byte order of constant instead of variable akpm
2008-03-26 4:36 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox