From: Breno Leitao <leitao@linux•vnet.ibm.com>
To: David Miller <davem@davemloft•net>
Cc: thockin@google•com, msb@google•com, netdev@vger•kernel.org,
jeff@garzik•org, joe@perches•com, nil@google•com, matthew@wil•cx
Subject: Re: [PATCH] [ETHTOOL]: Add support for large eeproms
Date: Thu, 24 Apr 2008 15:17:26 -0300 [thread overview]
Message-ID: <4810CEB6.60707@linux.vnet.ibm.com> (raw)
In-Reply-To: <20080415.192330.29185957.davem@davemloft.net>
David Miller wrote:
> From: "Tim Hockin" <thockin@google•com>
> Date: Tue, 15 Apr 2008 10:07:21 -0700
>
>
>> No device that I know of behaves that way. It's certainly possible,
>> but I've never seen any sort of PROM device that has such a
>> requirement.
>>
>
> Fair enough, let's apply the patch and see if anything explode :)
>
I've just applied this patch, and I got something really strange now. I
got the following message "Magic number 0x00000000 does not match 0x669955aa
" when I try to dump the eeprom from my tg3 card (BCM5780S rev. 03). I
suppose that somehow it isn't getting the correct NIC magic number.
Well, without the patch, I just got a "Cannnot allocate enough memory"
message when I rung the ethtool command, but if I pass the length
argument < 128k, then everything went ok.
Now, with the patch applied, I can't even dump even using the length
parameter, since I hit the same Magic number error.
Note that I didn't run the kernel from your tree, I just backport this
patch to my current kernel 2.6.16, and tried it over a ppc machine. I'll
run the kernel from your tree later and then post the result.
--
Breno Leitão
leitao@linux•vnet.ibm.com
next prev parent reply other threads:[~2008-04-24 18:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1207195123.23161.291.camel@localhost>
2008-04-03 18:00 ` [PATCH] [ETHTOOL]: Add support for large eeproms Mandeep Singh Baines
2008-04-04 0:03 ` Joe Perches
2008-04-04 1:41 ` Mandeep Singh Baines
2008-04-12 9:10 ` Jeff Garzik
2008-04-14 18:03 ` Mandeep Singh Baines
2008-04-15 7:31 ` David Miller
2008-04-15 17:07 ` Tim Hockin
2008-04-16 2:23 ` David Miller
2008-04-24 18:17 ` Breno Leitao [this message]
2008-04-24 19:01 ` Mandeep Singh Baines
2008-04-24 20:21 ` Breno Leitao
2008-04-25 1:15 ` Mandeep Singh Baines
2008-04-15 17:39 ` Mandeep Singh Baines
2008-04-16 2:24 ` David Miller
2008-04-03 2:12 Mandeep Singh Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4810CEB6.60707@linux.vnet.ibm.com \
--to=leitao@linux$(echo .)vnet.ibm.com \
--cc=davem@davemloft$(echo .)net \
--cc=jeff@garzik$(echo .)org \
--cc=joe@perches$(echo .)com \
--cc=matthew@wil$(echo .)cx \
--cc=msb@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nil@google$(echo .)com \
--cc=thockin@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox