* [PATCH] NET: Remove PACKET_FASTROUTE
@ 2008-05-07 9:07 Wang Chen
2008-05-07 9:35 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Wang Chen @ 2008-05-07 9:07 UTC (permalink / raw)
To: David S. Miller; +Cc: NETDEV
Since we do not support fastroute anymore, remove macro PACKET_FASTROUTE.
Signed-off-by: Wang Chen <wangchen@cn•fujitsu.com>
---
include/linux/if_packet.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/include/linux/if_packet.h b/include/linux/if_packet.h
index ad09609..d109a0f 100644
--- a/include/linux/if_packet.h
+++ b/include/linux/if_packet.h
@@ -30,7 +30,6 @@ struct sockaddr_ll
#define PACKET_OUTGOING 4 /* Outgoing of any type */
/* These ones are invisible by user level */
#define PACKET_LOOPBACK 5 /* MC/BRD frame looped back */
-#define PACKET_FASTROUTE 6 /* Fastrouted frame */
/* Packet socket options */
--
1.5.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] NET: Remove PACKET_FASTROUTE
2008-05-07 9:07 [PATCH] NET: Remove PACKET_FASTROUTE Wang Chen
@ 2008-05-07 9:35 ` David Miller
2008-05-07 9:45 ` Wang Chen
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2008-05-07 9:35 UTC (permalink / raw)
To: wangchen; +Cc: netdev
From: Wang Chen <wangchen@cn•fujitsu.com>
Date: Wed, 07 May 2008 17:07:10 +0800
> Since we do not support fastroute anymore, remove macro PACKET_FASTROUTE.
>
> Signed-off-by: Wang Chen <wangchen@cn•fujitsu.com>
We should leave it there so that this value is not accidently
allocatod to another purpose.
If you really really want to remove it, at least add a comment
there that value "6" used to be allocated to PACKET_FASTROUTE,
and therefore cannot be reused.
But, to be honest, keeping the define there serves that purpose just
as well.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] NET: Remove PACKET_FASTROUTE
2008-05-07 9:35 ` David Miller
@ 2008-05-07 9:45 ` Wang Chen
0 siblings, 0 replies; 3+ messages in thread
From: Wang Chen @ 2008-05-07 9:45 UTC (permalink / raw)
To: David Miller; +Cc: netdev
David Miller said the following on 2008-5-7 17:35:
> From: Wang Chen <wangchen@cn•fujitsu.com>
> Date: Wed, 07 May 2008 17:07:10 +0800
>
>> Since we do not support fastroute anymore, remove macro PACKET_FASTROUTE.
>>
>> Signed-off-by: Wang Chen <wangchen@cn•fujitsu.com>
>
> We should leave it there so that this value is not accidently
> allocatod to another purpose.
>
> If you really really want to remove it, at least add a comment
> there that value "6" used to be allocated to PACKET_FASTROUTE,
> and therefore cannot be reused.
>
> But, to be honest, keeping the define there serves that purpose just
> as well.
>
Yes. I agree. So leave it there.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-07 9:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-07 9:07 [PATCH] NET: Remove PACKET_FASTROUTE Wang Chen
2008-05-07 9:35 ` David Miller
2008-05-07 9:45 ` Wang Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox