* [patch 10/11] rndis_host: increase delay in command response loop
@ 2008-05-14 23:20 akpm
2008-05-22 10:04 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2008-05-14 23:20 UTC (permalink / raw)
To: jeff; +Cc: netdev, akpm, linkfanel, davem, david-b, greg
From: Pierre Ynard <linkfanel@yahoo•fr>
Some devices running some WinCE firmware (with SC_* Samsung processors
according to the SynCE project, verified on a HTC P3600 device) fail to
register because they apparently need extra time to respond correctly to
requests. Increase the existing delay to satisfy them. Based on code
from the SynCE project, on a suggestion of David Brownell.
This patch Works For Me(tm).
Signed-off-by: Pierre Ynard <linkfanel@yahoo•fr>
Acked-by: David Brownell <david-b@pacbell•net>
Cc: Greg KH <greg@kroah•com>
Cc: Jeff Garzik <jeff@garzik•org>
Cc: "David S. Miller" <davem@davemloft•net>
Signed-off-by: Andrew Morton <akpm@linux-foundation•org>
---
drivers/net/usb/rndis_host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/net/usb/rndis_host.c~rndis_host-increase-delay-in-command-response-loop drivers/net/usb/rndis_host.c
--- a/drivers/net/usb/rndis_host.c~rndis_host-increase-delay-in-command-response-loop
+++ a/drivers/net/usb/rndis_host.c
@@ -194,7 +194,7 @@ int rndis_command(struct usbnet *dev, st
dev_dbg(&info->control->dev,
"rndis response error, code %d\n", retval);
}
- msleep(2);
+ msleep(20);
}
dev_dbg(&info->control->dev, "rndis response timeout\n");
return -ETIMEDOUT;
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 10/11] rndis_host: increase delay in command response loop
2008-05-14 23:20 [patch 10/11] rndis_host: increase delay in command response loop akpm
@ 2008-05-22 10:04 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-05-22 10:04 UTC (permalink / raw)
To: akpm; +Cc: netdev, linkfanel, davem, david-b, greg
akpm@linux-foundation•org wrote:
> From: Pierre Ynard <linkfanel@yahoo•fr>
>
> Some devices running some WinCE firmware (with SC_* Samsung processors
> according to the SynCE project, verified on a HTC P3600 device) fail to
> register because they apparently need extra time to respond correctly to
> requests. Increase the existing delay to satisfy them. Based on code
> from the SynCE project, on a suggestion of David Brownell.
>
> This patch Works For Me(tm).
>
> Signed-off-by: Pierre Ynard <linkfanel@yahoo•fr>
> Acked-by: David Brownell <david-b@pacbell•net>
> Cc: Greg KH <greg@kroah•com>
> Cc: Jeff Garzik <jeff@garzik•org>
> Cc: "David S. Miller" <davem@davemloft•net>
> Signed-off-by: Andrew Morton <akpm@linux-foundation•org>
> ---
>
> drivers/net/usb/rndis_host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-22 10:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-14 23:20 [patch 10/11] rndis_host: increase delay in command response loop akpm
2008-05-22 10:04 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox